Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various UI improvements #6

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Various UI improvements #6

wants to merge 7 commits into from

Conversation

michaeltyson
Copy link

@michaeltyson michaeltyson commented Aug 5, 2021 •
edited
Loading

Hi! A few proposed changes here:

  1. A trivial one first: tweaked the appearance of the saved game list, so that it has a transparent background, and selected items have a semitransparent white background with rounded border,
  2. Updated joystick library to latest from bradhowes/Joystick,
  3. Implemented dual joysticks with standard scheme - left controls forward and sideways motion, right controls pitch and yaw,
  4. Adjusted joystick control curve from linear to power curve for more natural control,
  5. Revised joystick to use relative, rather than absolute position, for control, meaning it's less critical where the first touch occurs,
  6. Added tap on right joystick to fire,
  7. Tweaked control system in cl_input.c for smoother movement,
  8. Addressed an iOS quirk that caused random delays to the touch end event, causing mayhem

dnicolson
dnicolson reviewed Aug 5, 2021
View reviewed changes
Quake2-iOS/SavedGameViewController.swift
cell.backgroundColor = .clear
cell.selectedBackgroundView = UIView.init(frame: .zero)
cell.selectedBackgroundView?.backgroundColor = UIColor.init(white: 1, alpha: 0.2)
cell.selectedBackgroundView?.layer.cornerRadius = 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test these changes on tvOS? It appears as though the save games are unreadable now with white text on a white background that was fixed in #5.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guilty as charged! I hadn't tried it on tvOS. There we go; needed a storyboard update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnicolson dnicolson dnicolson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeltyson @dnicolson