Add auto-generated index.json file (#74) #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New feature in preparation for moving maps into a subdirectory. Consumers of the maps should use the index to look up the appropriate map for a given PinMAME ROM name.
tomlogic
force-pushed
the
feature/index
branch
from
29e9eb8 to
ea3dd97
Compare
Also adds a table summarizing which properties apply to each encoding. (The table includes a new "dipsw" encoding currently under development in a separate branch.)
Closed
francisdb
reviewed
Jan 2, 2025
francisdb
approved these changes
Jan 2, 2025
|
I think that keeping it at the top level is a good idea, and will allow for any directory structure we might want. For example, maybe there are multiple directories at the root level that hold maps. Instead of I'll merge this, and then get started on sorting maps for another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool to generate a root-level
index.jsonfile as the first step in resolving #74.Python implementation has support for using the index in its
devbranch.