-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xnos & shortcaption integration + Dockerization #93
Conversation
Great, thanks @dendrondal. It looks like the tests are failing on Travis at the moment. I've posted the error below and will take a look if you don't get it to me beforehand:
I'd definitely prefer a set of smaller pull requests, by feature, if you have time to do this, but I understand that you might not! Separate PRs are a little easier and quicker to review. |
The Travis build failing makes sense, since Xnos and Shortcaption aren't defined in the yaml. Will have to add that. I'll cherry-pick groups of commits by features and submit those as PRs. I'll do the Dockerization one after, because what I specify there depends on what's accepted. |
This PR contains all features outlined in #87 and also adds a Docker container with these changes, outlined in #72 . Please let me know if you would like me to split the commits by feature and pull request with each individually.