Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small edits: moved variables to metadata.yml to use in all output #95

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Small edits: moved variables to metadata.yml to use in all output #95

merged 1 commit into from
Oct 2, 2020

Conversation

davidverweij
Copy link
Contributor

In the existing implementation the code for the custom front page for the .pdf and the HTML export was written separately (not using joint variables). I've made some small edits:

  • moved the title, author, etc. to a metadata.yml file,
  • moved the content of 01_title_page.md to the template.tex
  • removed redundant code in the .html and .tex templates
  • rewrote those templates to use the variables in the metadata.yml file
  • added an optional subtitle variable

The resulting pdf and HTML is identical - except for the addition of a subtitle.

@davidverweij
Copy link
Contributor Author

Let me know if you want me to merge a new master into this PR, if you merge any of the other PR's - like #94 . Cheers!

@dendrondal
Copy link
Collaborator

I like the idea of splitting up the YAML. Would definitely wait for #94 to merge, just in case XNOS breaks something.

@tompollard
Copy link
Owner

Thanks @davidverweij, looks good! The pull request needs a rebase after #94 was merged. Would you like to do this, or shall I?

@davidverweij
Copy link
Contributor Author

davidverweij commented Oct 2, 2020

Apologies on the extreme delay! Holidays, deadlines and being new to rebasing caused me to put this down my to-do list. Anyway, I did a rebase and ran the code to test - all seems good from my end.

@tompollard
Copy link
Owner

No apologies needed! Looks great, thanks for doing this :)

@tompollard tompollard merged commit dd7797c into tompollard:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants