Skip to content

Commit

Permalink
Downgrade sprs to 0.9
Browse files Browse the repository at this point in the history
`sprs` was updated in 1ceab80. Turns out it actually caused a significant regression in speed during training. It's not yet clear what exact change from sprs caused this (likely something related to MulAcc) but downgrading sprs to 0.9.* fixes the issue.
  • Loading branch information
tomtung committed Dec 2, 2021
1 parent 5f3148d commit acd94d4
Show file tree
Hide file tree
Showing 5 changed files with 72 additions and 71 deletions.
60 changes: 30 additions & 30 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ clap = { version = "2.33.*", optional = true }
hashbrown = "0.11.*"
itertools = "0.10.*"
log = "0.4.*"
ndarray = { version = "0.15.*", features = ["serde-1"] }
ndarray = { version = "0.14.*", features = ["serde-1"] }
num-traits = "0.2.*"
order-stat = "0.1.*"
ordered-float = "2.8.*"
Expand All @@ -32,7 +32,7 @@ serde = { version = '1.0.*', features = ['derive'] }
serde_cbor = "0.11.*"
serde_json = "1.0.*"
simple_logger = { version = "1.13.*", optional = true }
sprs = { version = "0.11.*", features = ["serde"] }
sprs = { version = "0.9.*", features = ["serde"] }

[dev-dependencies]
assert_approx_eq = "1.1.*"
Expand Down
64 changes: 32 additions & 32 deletions c-api/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit acd94d4

Please sign in to comment.