This repository has been archived by the owner on Dec 22, 2018. It is now read-only.
Ability to use fs.chmodSync on the recorded file for #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeikel
reviewed
Apr 16, 2018
readme.md
Outdated
| @@ -59,6 +59,8 @@ For example, you can do: | |||
| * `createSubtitles` (bool): If `true` and singleVideo is also true, will create a SRT subtitles file with the name details of the currently running spec. Defaults to `true`. | |||
| The file will be saves to `baseDirectory/protractor-specs.srt`. | |||
|
|
|||
| * `chmod` (string): Will attempt so set the given chmod on saved video. Defaults to `none` which will use the default permission settings for the file. | |||
There was a problem hiding this comment.
Following the same style as the other entries in the readme, you should add an example in the readme as well.
more flexibility with access permission rights
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more flexibility with access permission rights
E.g. useful in CI environments where an automated user is running the tests and saving recordings for other people to access.