Merge pull request #782 from ton-blockchain/october_update

Merge developer branch

Changelog.md

@@ -1,3 +1,9 @@
+## 2023.10 Update
+1. A series of additional security checks in node: special cells in action list, init state in external messages, peers data prior to saving to disk.
+2. Human-readable timestamps in explorer
+
+Besides the work of the core team, this update is based on the efforts of @akifoq and @mr-tron.
+
 ## 2023.06 Update
 1. (disabled by default) New deflation mechanisms: partial fee burning and blackhole address
 2. Storage-contract improvement

blockchain-explorer/blockchain-explorer-http.cpp

@@ -35,9 +35,38 @@
 #include "vm/cells/MerkleProof.h"
 #include "block/mc-config.h"
 #include "ton/ton-shard.h"
+#include "td/utils/date.h"
 
 bool local_scripts{false};
 
+static std::string time_to_human(unsigned ts) {
+  td::StringBuilder sb;
+  sb << date::format("%F %T",
+                     std::chrono::time_point<std::chrono::system_clock, std::chrono::seconds>{std::chrono::seconds(ts)})
+     << ", ";
+  auto now = (unsigned)td::Clocks::system();
+  bool past = now >= ts;
+  unsigned x = past ? now - ts : ts - now;
+  if (!past) {
+    sb << "in ";
+  }
+  if (x < 60) {
+    sb << x << "s";
+  } else if (x < 3600) {
+    sb << x / 60 << "m " << x % 60 << "s";
+  } else if (x < 3600 * 24) {
+    x /= 60;
+    sb << x / 60 << "h " << x % 60 << "m";
+  } else {
+    x /= 3600;
+    sb << x / 24 << "d " << x % 24 << "h";
+  }
+  if (past) {
+    sb << " ago";
+  }
+  return sb.as_cslice().str();
+}
+
 HttpAnswer& HttpAnswer::operator<<(AddressCell addr_c) {
   ton::WorkchainId wc;
   ton::StdSmcAddress addr;
@@ -84,7 +113,7 @@ HttpAnswer& HttpAnswer::operator<<(MessageCell msg) {
             << "<tr><th>source</th><td>" << AddressCell{info.src} << "</td></tr>\n"
             << "<tr><th>destination</th><td>NONE</td></tr>\n"
             << "<tr><th>lt</th><td>" << info.created_lt << "</td></tr>\n"
-            << "<tr><th>time</th><td>" << info.created_at << "</td></tr>\n";
+            << "<tr><th>time</th><td>" << info.created_at << " (" << time_to_human(info.created_at) << ")</td></tr>\n";
       break;
     }
     case block::gen::CommonMsgInfo::int_msg_info: {
@@ -103,7 +132,7 @@ HttpAnswer& HttpAnswer::operator<<(MessageCell msg) {
             << "<tr><th>source</th><td>" << AddressCell{info.src} << "</td></tr>\n"
             << "<tr><th>destination</th><td>" << AddressCell{info.dest} << "</td></tr>\n"
             << "<tr><th>lt</th><td>" << info.created_lt << "</td></tr>\n"
-            << "<tr><th>time</th><td>" << info.created_at << "</td></tr>\n"
+            << "<tr><th>time</th><td>" << info.created_at << " (" << time_to_human(info.created_at) << ")</td></tr>\n"
             << "<tr><th>value</th><td>" << value << "</td></tr>\n";
       break;
     }
@@ -277,7 +306,7 @@ HttpAnswer& HttpAnswer::operator<<(TransactionCell trans_c) {
         << "<tr><th>account</th><td>" << trans_c.addr.rserialize(true) << "</td></tr>"
         << "<tr><th>hash</th><td>" << trans_c.root->get_hash().to_hex() << "</td></tr>\n"
         << "<tr><th>lt</th><td>" << trans.lt << "</td></tr>\n"
-        << "<tr><th>time</th><td>" << trans.now << "</td></tr>\n"
+        << "<tr><th>time</th><td>" << trans.now << " (" << time_to_human(trans.now) << ")</td></tr>\n"
         << "<tr><th>out messages</th><td>";
   vm::Dictionary dict{trans.r1.out_msgs, 15};
   for (td::int32 i = 0; i < trans.outmsg_cnt; i++) {
@@ -456,7 +485,7 @@ HttpAnswer& HttpAnswer::operator<<(BlockHeaderCell head_c) {
           << "<tr><th>block</th><td>" << block_id.id.to_str() << "</td></tr>\n"
           << "<tr><th>roothash</th><td>" << block_id.root_hash.to_hex() << "</td></tr>\n"
           << "<tr><th>filehash</th><td>" << block_id.file_hash.to_hex() << "</td></tr>\n"
-          << "<tr><th>time</th><td>" << info.gen_utime << "</td></tr>\n"
+          << "<tr><th>time</th><td>" << info.gen_utime << " (" << time_to_human(info.gen_utime) << ")</td></tr>\n"
           << "<tr><th>lt</th><td>" << info.start_lt << " .. " << info.end_lt << "</td></tr>\n"
           << "<tr><th>global_id</th><td>" << blk.global_id << "</td></tr>\n"
           << "<tr><th>version</th><td>" << info.version << "</td></tr>\n"
@@ -543,7 +572,8 @@ HttpAnswer& HttpAnswer::operator<<(BlockShardsCell shards_c) {
       ton::ShardIdFull shard{id.workchain, id.shard};
       if (ref.not_null()) {
         *this << "<td>" << shard.to_str() << "</td><td><a href=\"" << HttpAnswer::BlockLink{ref->top_block_id()}
-              << "\">" << ref->top_block_id().id.seqno << "</a></td><td>" << ref->created_at() << "</td>"
+              << "\">" << ref->top_block_id().id.seqno << "</a></td><td><span title=\""
+              << time_to_human(ref->created_at()) << "\">" << ref->created_at() << "</span></td>"
               << "<td>" << ref->want_split_ << "</td>"
               << "<td>" << ref->want_merge_ << "</td>"
               << "<td>" << ref->before_split_ << "</td>"

crypto/block/transaction.cpp

@@ -943,7 +943,12 @@ int output_actions_count(Ref<vm::Cell> list) {
   int i = -1;
   do {
     ++i;
-    list = load_cell_slice(std::move(list)).prefetch_ref();
+    bool special = true;
+    auto cs = load_cell_slice_special(std::move(list), special);
+    if (special) {
+      break;
+    }
+    list = cs.prefetch_ref();
   } while (list.not_null());
   return i;
 }
@@ -1060,6 +1065,11 @@ bool Transaction::prepare_compute_phase(const ComputePhaseConfig& cfg) {
   } else if (in_msg_state.not_null()) {
     unpack_msg_state(true);  // use only libraries
   }
+  if (in_msg_extern && in_msg_state.not_null() && account.addr != in_msg_state->get_hash().bits()) {
+    LOG(DEBUG) << "in_msg_state hash mismatch in external message";
+    cp.skip_reason = ComputePhase::sk_bad_state;
+    return true;
+  }
   // initialize VM
   Ref<vm::Stack> stack = prepare_vm_stack(cp);
   if (stack.is_null()) {
@@ -1122,7 +1132,8 @@ bool Transaction::prepare_compute_phase(const ComputePhaseConfig& cfg) {
     int out_act_num = output_actions_count(cp.actions);
     if (verbosity > 2) {
       std::cerr << "new smart contract data: ";
-      load_cell_slice(cp.new_data).print_rec(std::cerr);
+      bool can_be_special = true;
+      load_cell_slice_special(cp.new_data, can_be_special).print_rec(std::cerr);
       std::cerr << "output actions: ";
       block::gen::OutList{out_act_num}.print_ref(std::cerr, cp.actions);
     }
@@ -1192,7 +1203,15 @@ bool Transaction::prepare_action_phase(const ActionPhaseConfig& cfg) {
   int n = 0;
   while (true) {
     ap.action_list.push_back(list);
-    auto cs = load_cell_slice(std::move(list));
+    bool special = true;
+    auto cs = load_cell_slice_special(std::move(list), special);
+    if (special) {
+      ap.result_code = 32;  // action list invalid
+      ap.result_arg = n;
+      ap.action_list_invalid = true;
+      LOG(DEBUG) << "action list invalid: special cell";
+      return true;
+    }
     if (!cs.size_ext()) {
       break;
     }

overlay/overlay.cpp

@@ -291,7 +291,11 @@ void OverlayImpl::alarm() {
       if (peers_.size() > 0) {
         std::vector<OverlayNode> vec;
         for (td::uint32 i = 0; i < 20; i++) {
-          vec.push_back(get_random_peer()->get());
+          auto P = get_random_peer();
+          if (!P) {
+            break;
+          }
+          vec.push_back(P->get());
         }
         td::actor::send_closure(manager_, &OverlayManager::save_to_db, local_id_, overlay_id_, std::move(vec));
       }