Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dict_delete_get_min and max functions #712

Open
wants to merge 1 commit into
base: testnet
Choose a base branch
from
Open

Fix dict_delete_get_min and max functions #712

wants to merge 1 commit into from

Commits on May 27, 2023

  1. Fix dict_delete_get_min and max functions 

    I checked all functions in stdlib, and all of the functions that returns a boolean have a ? suffix, except for dict_delete_get_min and dict_delete_get_max functions, which together with udict and idict versions and modifying versions are a total of 12 functions.

Also removed `::` from modifying versions of these functions since this was the only place in stdlib that they were used, and it makes them more similar to non-modifying versions.

It should not be a breaking change, since old users are using a copy of this stdlib and will not be affected, unless they update their library.
    @behrang
    behrang authored May 27, 2023
    Configuration menu
    Copy the full SHA
    9c44c61 View commit details
    Browse the repository at this point in the history