Add Windows file ownership code #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
force-pushed
the
windows-file-ownership-ops
branch
from
b378366
to
1ed2012
Compare
|
Sorry about the previous omission. Tests should pass now. |
tonistiigi
approved these changes
Nov 8, 2022
copy/mkdir_windows.go
Outdated
| } | ||
| var userSID *windows.SID | ||
| if err := windows.ConvertStringSidToSid(sidPtr, &userSID); err != nil { | ||
| return fmt.Errorf("converting to windows SID: %w", err) |
There was a problem hiding this comment.
Nit: use errors.Errorf so the stacktrace does not get lost.
There was a problem hiding this comment.
@gabriel-samfira Could you fix this small issue and rebase. I think we can merge this then.
There was a problem hiding this comment.
Yes. Doing it ASAP.
Side note: will also have a new PR soon with fixes for windows across the rest of the repo and a workflow to test on windows.
|
@gabriel-samfira Could you also look into setting up actual windows CI workflow for this repo? |
|
@tonistiigi Sure! Will have a look this week. |
|
@tonistiigi Added an issue to track the Windows CI workflow here #142 |
gabriel-samfira
force-pushed
the
windows-file-ownership-ops
branch
from
1ed2012
to
27d81c4
Compare
This change adds the ability to copy Windows file ownership and security information, as well as implement proper Chown(). Signed-off-by: Gabriel Adrian Samfira <[email protected]>
gabriel-samfira
force-pushed
the
windows-file-ownership-ops
branch
from
27d81c4
to
b277694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to copy Windows file ownership and security information, as well as implement proper Chown() for Windows.
Signed-off-by: Gabriel Adrian Samfira [email protected]