Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive: ensure file path matches os-style form when registering #186

Closed
wants to merge 1 commit into from

Conversation

crazy-max
Copy link
Collaborator

@crazy-max crazy-max commented Feb 23, 2024

fixes docker/buildx#2207
related to docker/buildx#2207 (comment)

When sending files, path will be sent through the wire and treated as-is on the receiver side. We need to make sure receiver side matches its local form when registering. This is specially important on Windows where filepath.FromSlash on sender side converts / into \.

cc @jedevc @gabriel-samfira

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@b847aa4). Click here to learn what that means.

Files Patch % Lines
receive.go 40.00% 1 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #186   +/-   ##
=========================================
  Coverage          ?   64.51%           
=========================================
  Files             ?       29           
  Lines             ?     1939           
  Branches          ?        0           
=========================================
  Hits              ?     1251           
  Misses            ?      453           
  Partials          ?      235           
Flag Coverage Δ
go-1.20 64.65% <40.00%> (?)
go-1.21 64.51% <40.00%> (?)
noroot 62.88% <40.00%> (?)
root 64.27% <40.00%> (?)
unit 64.51% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazy-max crazy-max marked this pull request as ready for review February 23, 2024 16:55
@crazy-max crazy-max deleted the fix-receive branch February 24, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsutil error expected single entry
2 participants