fix correcting timestamps for created destination dir after copy #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
crazy-max
reviewed
Oct 22, 2024
| return err | ||
| } else { | ||
| defer fixCreatedParentDirs(createdDirs, ci.Utime) |
There was a problem hiding this comment.
Related to docker/buildx#2745 (comment), could we apply ownership as well?:
Suggested change
| defer fixCreatedParentDirs(createdDirs, ci.Utime) | |
| defer fixCreatedParentDirs(createdDirs, ci.Chown, ci.Utime) |
There was a problem hiding this comment.
The issue is that although target directories are created with requested timestamp, when files are written into them it changes the modified time. So the modified time needs to be reset again after the copy. This problem does not exist for chown.
There is another weird case in this code where target dirs are always created with default 755 mode, even if --chmod is set. Not sure if this is correct, but not directly part of this issue.
crazy-max
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #207
@smira