Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build on OpenBSD #215

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fixed build on OpenBSD #215

merged 1 commit into from
Nov 1, 2024

Conversation

catap
Copy link
Contributor

@catap catap commented Nov 1, 2024

This fixes docker/buildx#2772

Copy link
Owner

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this to CI as well. If the tests can't run, then at least check that it builds.

@tonistiigi
Copy link
Owner

@tonistiigi tonistiigi merged commit 2406230 into tonistiigi:master Nov 1, 2024
19 checks passed
@catap catap deleted the openbsd-copy branch November 1, 2024 20:00
@catap
Copy link
Contributor Author

catap commented Nov 1, 2024

@tonistiigi seems that it requires a bit more work what just add it into this file. At least I see that dedicated instance with VM via vargand is required.

@tonistiigi
Copy link
Owner

Vagrant would be needed to run the tests. To just check that code builds doesn't need it.

@catap
Copy link
Contributor Author

catap commented Nov 1, 2024

Here my attempt: https://github.com/catap/fsutil/tree/openbsd-ci

if you think that it’s enough I ready to open PR

@catap
Copy link
Contributor Author

catap commented Nov 1, 2024

Tuis, I had run it as: https://github.com/catap/fsutil/actions/runs/11635591513

@crazy-max crazy-max mentioned this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build 0.18.0 on OpenBSD
2 participants