Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loong64 support for src #130

Closed
wants to merge 3 commits into from
Closed

Conversation

yzewei
Copy link

@yzewei yzewei commented Dec 5, 2023

moby/buildkit#4392

I'm sorry to complete this PR so late. I am busy some time ago. I have only been free now. Thank you very much for your attention!

Let me give you the lowdown once again: Loongarch, also known as Loongarch, is a badass RISC-style Instruction Set Architecture (ISA). It's all the rage in the open-source community and has been rocking long-term support.

@yzewei yzewei changed the title add loong64 support for src/ add loong64 support for src Dec 5, 2023
@yzewei
Copy link
Author

yzewei commented Dec 5, 2023

@tonistiigi @tiborvass Thanks!

src/xx-apt Outdated Show resolved Hide resolved
@tonistiigi
Copy link
Owner

Don't forget to enable CI as well and add extra tests where needed (eg. in info at least).

@yzewei
Copy link
Author

yzewei commented Dec 5, 2023

Don't forget to enable CI as well and add extra tests where needed (eg. in info at least).

The latest commit adds test-related code

src/xx-apt Outdated
apt-get update
apt-get install -y debian-ports-archive-keyring
if [ -z "$XX_APT_REPO_URL_LOONGARCH64" ]; then
echo "Please set the environment variable XX_APT_REPO_URL_LOONGARCH64=pkg.loongnix.cn"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://ftp.ports.debian.org/debian-ports/pool-loong64/ does not work as a default?

At present, this link does not work. Can it be for the time being, and then correct it after actual use?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue with the debian link?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue with the debian link?

Since the ABI atmosphere ABI 1.0 and ABI2.0 under the ABI atmosphere under Loongarch, the current debian official source link supports ABI2.0. The source link in the current code is the ABI 1.0 software source maintained by Loongarch, ABI1.0 and ABI2.0 The distinction can be performed through Loongarch64 and Loong64. Thank you for your reminder!

src/xx-apt Outdated
echo "Please set the environment variable XX_APT_REPO_URL_LOONGARCH64=pkg.loongnix.cn"
exit 0;
fi
echo "deb [ arch=loongarch64 ] http://pkg.loongnix.cn/loongnix DaoXiangHu-stable main contrib non-free" >>/etc/apt/sources.list.d/loongarch64.list
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use the env as well. You can put the distro in another env or combine them somehow.

src/xx-info Outdated
@@ -337,6 +340,14 @@ case "$TARGETARCH" in
XX_RHEL_ARCH="mips64el"
XX_TRIPLE="mips64el${vendor}-linux-${XX_LIBC}abi64"
;;
"loongarch64")
XX_MARCH="loongarch64"
XX_DEBIAN_ARCH="loongarch64"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like debian name is loong64 ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as the above problem, I will add

src/xx-apk Outdated Show resolved Hide resolved
@tonistiigi
Copy link
Owner

PTAL CI failures. Looks like at least an issue with the xx-verify

@yzewei

This comment was marked as abuse.

@yzewei
Copy link
Author

yzewei commented Dec 28, 2023

It seems that the test-clang.bats file's verification of ppc64le and armv8 has problems that cause the CI failure

@yzewei

This comment was marked as abuse.

@yzewei
Copy link
Author

yzewei commented Jan 5, 2024

util/bats-assert/Dockerfile has a problem with the build image, and it has been corrected

Copy link
Owner

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bats issue covered by #134

src/test-go.bats Outdated Show resolved Hide resolved
src/test-go.bats Show resolved Hide resolved
src/test-info-alpine.bats Outdated Show resolved Hide resolved
src/xx-apk Show resolved Hide resolved
src/xx-cargo Outdated Show resolved Hide resolved
@@ -127,7 +127,8 @@ target "_all-platforms" {
"linux/mips64le",
"linux/ppc64le",
"linux/s390x",
"linux/riscv64"
"linux/riscv64",
"linux/loong64"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace issue here and other places in HCL

src/test-clang.bats Outdated Show resolved Hide resolved
@yzewei yzewei force-pushed the master branch 3 times, most recently from be84379 to 2008cc9 Compare January 5, 2024 09:22
Signed-off-by: yzewei <[email protected]>
@yzewei yzewei deleted the branch tonistiigi:master January 6, 2024 01:46
@yzewei yzewei closed this Jan 6, 2024
@yzewei yzewei deleted the master branch January 6, 2024 01:46
@yzewei yzewei mentioned this pull request Jan 6, 2024
@yzewei
Copy link
Author

yzewei commented Jan 6, 2024

@tonistiigi @crazy-max The PR of add loong64 support has been moved 139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants