-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aggregation in Windows (fix #210) #211
Merged
tonybaloney
merged 14 commits into
tonybaloney:master
from
devdanzin:fix_aggregate_in_windows
Sep 4, 2023
Merged
Fix aggregation in Windows (fix #210) #211
tonybaloney
merged 14 commits into
tonybaloney:master
from
devdanzin:fix_aggregate_in_windows
Sep 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 95.83% 95.84%
=======================================
Files 25 25
Lines 1346 1349 +3
Branches 287 289 +2
=======================================
+ Hits 1290 1293 +3
Misses 32 32
Partials 24 24
|
Sorry about the noise, I couldn't get codecov to pass without adding tests, and I couldn't make the tests fail locally the same way they did on CI. |
tonybaloney
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, aggregation is broken in two ways:
src/
andtest/
in wily's repo, but notsrc/wily/
).This happens because
revision.tracked_files
andrevision.tracked_dirs
store paths with forward slashes, but the paths inresult
use backslashes in Windows. This PR fixes that by converting entries in those lists toPath
s and back tostr
.This fixes the root cause of #210, which initially had a wrong analysis but documents the issue.