Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore displaying graph markers #215

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

devdanzin
Copy link
Collaborator

@devdanzin devdanzin commented Aug 28, 2023

When #205 landed, we stopped setting z_axis to None, but still test it against being None. This causes the sizeof marker to be an empty list instead of zero, hiding graph markers. This tiny PR fixes that.

Before:
marker_before

After:
marker_after

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #215 (ba62ad6) into master (b342a1c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          25       25           
  Lines        1346     1346           
  Branches      287      287           
=======================================
  Hits         1290     1290           
  Misses         32       32           
  Partials       24       24           
Files Changed Coverage Δ
src/wily/commands/graph.py 100.00% <ø> (ø)

@tonybaloney tonybaloney merged commit 6f5cd5d into tonybaloney:master Sep 4, 2023
17 checks passed
@tonybaloney
Copy link
Owner

thanks!

@devdanzin devdanzin deleted the restore_markers branch September 5, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants