Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute project structure #236

Merged
merged 51 commits into from
Jul 6, 2023
Merged

Absolute project structure #236

merged 51 commits into from
Jul 6, 2023

Conversation

tonykolomeytsev
Copy link
Owner

@tonykolomeytsev tonykolomeytsev commented Jul 2, 2023 •
edited
Loading

Перехожу на структуру проекта, которая подходит дял использования с билд системой Bazel и мета-билд системой Forma.
Модуляризация на максималках. По мотивам доклада Степана Гончарова - "абсолютная модуляризация"

Шаги модуляризации:

  • Описать новые convention плагины
  • Избавиться от common-модулей и разделить их все на ext и library модули.
    • ext (extension) модули - расширения внешних библиотек. Эти модули не имеют ресурсов или зависимостей от других модулей.
    • library - библиотечные модули. Чаще всего в них отсутствуют ресурсы, но они могут зависеть от других модулей и даже иметь свои DI модули.
  • Смержить domain и feature модули в feature_*_api и feature_*_impl модули.
  • Убрать модули из директории resources/
  • Обновить ARCHITECTURE.md

@tonykolomeytsev
Create convention for feature impl modules
36e9af1
@tonykolomeytsev
Create convention for feature api modules
a54343b
@tonykolomeytsev
Create convention for kotlin library and kotlin extension
35d00d2
@tonykolomeytsev
Create convention for android library, android extension
4ff935b
@tonykolomeytsev
Fix compose plugin
b6c5a46
@tonykolomeytsev
Fix android minimal compose plugin, add android application convention
f9ee6ef
@tonykolomeytsev
Fix all found issues in convention plugins
11aeccd
@tonykolomeytsev
Migrate ui modules to mpeix.android.ui and mpeix.android.res conv…
42bb53f 
…entions
@tonykolomeytsev
Create :ext_koin module
020178d
@tonykolomeytsev
Create library_chucker module
13b5709
@tonykolomeytsev
Create library_persistent_cache module
31a14f9
@tonykolomeytsev
Create library_app_database module
960993c
@tonykolomeytsev
Create library_elm module
2b88b2e
@tonykolomeytsev
Create ext_kotlin module
c21d3c5
@tonykolomeytsev
Create library_coroutines module
efd8592
@tonykolomeytsev
Create library_app_lifecycle module
9cfecc0
@tonykolomeytsev
Create library_navigation module
76362b4
@tonykolomeytsev
Create library_feature_toggles module
cf2a80a
@tonykolomeytsev
Create library_adapter module
8d17110
@tonykolomeytsev
Create library_app_info module
6fbc20b
@tonykolomeytsev
Create mock_server module
c00b772
@tonykolomeytsev
Create ext_android module
789fc39
@tonykolomeytsev
Create library_emoji module
7e5f0a9
@tonykolomeytsev
Create library_schedule module
42c8da7
@tonykolomeytsev
Create debug_menu module
3425106
@tonykolomeytsev
Create library_analytics module
3e5f49e
@tonykolomeytsev
Move database schema to the new location
5029fd8
@tonykolomeytsev tonykolomeytsev marked this pull request as draft July 2, 2023 18:58
@tonykolomeytsev
Merge :domain_app_settings and :feature_app_settings modules
113c718 
- Create `:feature_app_settings_(api|impl)` modules
@tonykolomeytsev
Merge :domain_bars and :feature_bars modules
00905a7 
- Create `:feature_bars_(api|impl)` modules
@tonykolomeytsev tonykolomeytsev force-pushed the absolute-project-structure branch 2 times, most recently from 99f4421 to 16f85bf Compare July 3, 2023 12:25
@tonykolomeytsev
Merge :domain_dashboard and :feature_dashboard modules
c8bf900 
- Create `:feature_dashboard_(api|impl)` modules
@tonykolomeytsev
Merge :domain_force_update and :feature_force_update modules
351314b 
- Create `:feature_app_update_(api|impl)` modules
@tonykolomeytsev
Merge :domain_map and :feature_map modules
07e18db 
- Create `:feature_map_(api|impl)` modules
@tonykolomeytsev
Merge :domain_onboarding and :feature_onboarding modules
8953c04 
- Create `:feature_onboarding_(api|impl)` modules
@tonykolomeytsev
Merge :domain_search and :feature_search modules
69b6d51 
- Create `:feature_search_(api|impl)` modules
@tonykolomeytsev
Merge notes and favorite_schedule modules
4db5ba0 
- Create `:feature_notes_(api|impl)` modules
- Create `:feature_favorite_schedule_(api|impl)` modules
- Refactor library_app_database
@tonykolomeytsev
Rename DI modules
1e31744
@tonykolomeytsev
Merge all *schedule modules to :feature_schedule_(api|impl) modules
3d03ab0
@tonykolomeytsev
Create :feature_main_screen_api module
7a059d8
@tonykolomeytsev
Create :feature_contributors_(api|impl) modules
0acc419
@tonykolomeytsev tonykolomeytsev marked this pull request as ready for review July 6, 2023 10:11
@tonykolomeytsev tonykolomeytsev merged commit 3c59d29 into dev Jul 6, 2023
@tonykolomeytsev tonykolomeytsev deleted the absolute-project-structure branch July 6, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tonykolomeytsev