New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Content Attachments #59

Merged

tonysm merged 3 commits into main from tm/attachment-html-content

Oct 14, 2024

Owner

tonysm commented Oct 14, 2024 •

edited

Loading

Changed

Following up on update ContentAttachment so that it works with "content" attributes rails/rails#45739, looks like the previous horizontal rule was a leftover from BC3 that was never extracted. As I was porting it here, I wrote tests for the previous horizontal rule approach, but I'm not treating this as a BC-break, since the OP said the old model was broken and unused.

tonysm and others added 3 commits

October 14, 2024 19:34


          Allow for HTML content attachments

8c33cbb


          Assert the log call

0572cc6


          Fix styling

8096a0f

tonysm merged commit 3cd2b3d into main

8 checks passed

tonysm deleted the tm/attachment-html-content branch

October 14, 2024 22:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet