Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gentoo images #91

Closed
wants to merge 1 commit into from
Closed

Conversation

cheese
Copy link

@cheese cheese commented Aug 4, 2023

This PR creates two images based on upstream ones with tags latest and systemd.

@travier
Copy link
Member

travier commented Aug 4, 2023

Mostly LGTM. I would prefer that we don't carry our own ebuilds here but if it's not in Gentoo then I don't know what the best option is. Would submitting it to Gentoo be an option? Sorry, I'm not up-to-date on Gentoo policies.

@cheese
Copy link
Author

cheese commented Aug 5, 2023

Or is that acceptable to not carry flatpak-spawn for now?

@cheese cheese marked this pull request as draft August 5, 2023 08:24
@cheese cheese marked this pull request as ready for review August 7, 2023 02:06
@travier
Copy link
Member

travier commented Aug 7, 2023

Or is that acceptable to not carry flatpak-spawn for now?

I'd say it's better to have flatpak-spawn in the image but that means that you will have to maintain it here.

@cheese cheese marked this pull request as draft August 7, 2023 09:49
@cheese cheese marked this pull request as ready for review August 7, 2023 13:09
@cheese cheese marked this pull request as draft August 7, 2023 15:56
@cheese cheese marked this pull request as ready for review August 8, 2023 02:28
This PR creates two images based on upstream ones with tags `latest` and
`systemd`.
@travier
Copy link
Member

travier commented Aug 9, 2023

Well, this is taking more than 6 hours to complete, so this is probably better done in another place, maybe in the Gentoo infrastructure.

@cheese cheese closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants