PM-1314 Make grouping by status optional #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -21,6 +21,25 @@ module.exports = [ | |||
| const pageSize = parseInt(req.query.pageSize, 10) || DEFAULT_PAGE_SIZE; | |||
| const offset = (page - 1) * pageSize; | |||
| const limit = pageSize; | |||
| const noGroupingByStatus = req.query.noGrouping === 'true'; | |||
There was a problem hiding this comment.
Consider renaming the variable noGroupingByStatus to something more intuitive, such as isGroupingByStatusDisabled, to clarify that it represents a boolean flag indicating whether grouping is disabled.
| 'ASC', | ||
| ]); | ||
| } | ||
| baseOrder.push([sortParams[0], sortParams[1]]); |
There was a problem hiding this comment.
Ensure that sortParams is properly validated before being used in baseOrder.push([sortParams[0], sortParams[1]]);. This will prevent potential runtime errors if sortParams is undefined or not an array with at least two elements.
kkartunov
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the grouping optional so that we have grouped data on copilots portal and can opt for ungrouped data on community app