feat(PM-1611): send email when opportunity is completed or canceled #849

hentrymartin · 2025-08-18T15:42:16Z

What's in this PR?

send email when opportunity is completed or canceled

Ticket link - https://topcoder.atlassian.net/browse/PM-1611

github-actions · 2025-08-18T15:42:39Z

src/routes/copilotOpportunity/assign.js

+
+  const users = await util.getMemberDetailsByUserIds(userIds, req.log, req.id);
+
+  users.forEach(async (user) => {


Using forEach with an async function can lead to unexpected behavior because the asynchronous operations inside the loop won't be awaited. Consider using a for...of loop or Promise.all to handle asynchronous operations properly.

github-actions · 2025-08-18T15:42:39Z

src/routes/copilotOpportunity/assign.js

+    const requestData = copilotRequest.data;
+    createEvent(emailEventType, {
+      data: {
+        opportunity_details_url: `${copilotPortalUrl}/opportunity`,


The URL construction for opportunity_details_url might need to include the specific opportunity ID or other identifiers to ensure the link directs to the correct opportunity details page.

github-actions · 2025-08-18T15:42:39Z

src/routes/copilotOpportunity/assign.js

+      data: {
+        opportunity_details_url: `${copilotPortalUrl}/opportunity`,
+        opportunity_title: requestData.opportunityTitle,
+        user_name: user ? user.handle : "",


Consider handling the case where user might be null or undefined more explicitly to avoid potential errors when accessing user.handle.

github-actions · 2025-08-18T15:42:43Z

src/routes/copilotOpportunity/assign.js

@@ -134,6 +169,9 @@ module.exports = [
        }, req.log);

        req.log.debug(`Email sent`);
+
+        // Send email to all applicants about opportunity completion
+        await sendEmailToAllApplicants(req, opportunity, copilotRequest, application.id);


Consider handling potential errors from the sendEmailToAllApplicants function. If the email sending fails, it might be useful to log the error or take corrective actions.

github-actions · 2025-08-18T15:42:45Z

src/routes/copilotOpportunity/delete.js

+  const userIds = applications.map(item => item.userId);
+  const users = await util.getMemberDetailsByUserIds(userIds, req.log, req.id);
+
+  users.forEach(async (user) => {


Consider using Promise.all to handle asynchronous operations in the users.forEach loop. This will ensure that all email sending operations are completed before proceeding, and it will also handle errors more effectively.

github-actions · 2025-08-18T15:42:45Z

src/routes/copilotOpportunity/delete.js

+    const requestData = copilotRequest.data;
+    createEvent(emailEventType, {
+      data: {
+        opportunity_details_url: `${copilotPortalUrl}/opportunity`,


The URL concatenation for opportunity_details_url may lead to incorrect URLs if copilotPortalUrl does not end with a slash. Consider using a URL library or ensuring the base URL ends with a slash to prevent potential issues.

github-actions · 2025-08-18T15:42:48Z

src/routes/copilotOpportunity/delete.js

@@ -93,6 +120,8 @@ module.exports = [
          invite.toJSON());
      }

+      await sendEmailToAllApplicants(req, copilotRequest, applications)


It seems like the function sendEmailToAllApplicants is being called here, but there is no error handling around this asynchronous operation. Consider adding a try-catch block to handle any potential errors that may occur during the email sending process.

github-actions · 2025-08-18T19:43:58Z

src/routes/copilotOpportunity/assign.js

+
+      const users = await util.getMemberDetailsByUserIds(userIds, req.log, req.id);
+
+      users.forEach(async (user) => {


Consider using a Promise.all to handle asynchronous operations in the forEach loop. This will ensure that all emails are sent before proceeding, and can help catch any errors in the email sending process.

github-actions · 2025-08-18T19:43:58Z

src/routes/copilotOpportunity/assign.js

+          data: {
+            opportunity_details_url: `${copilotPortalUrl}/opportunity`,
+            opportunity_title: requestData.opportunityTitle,
+            user_name: user ? user.handle : "",


The user_name field is being set to an empty string if user is falsy. Consider handling cases where user might be undefined or null more explicitly to avoid sending incomplete data.

github-actions · 2025-08-18T19:44:01Z

src/routes/copilotOpportunity/assign.js

@@ -134,6 +169,9 @@ module.exports = [
        }, req.log);

        req.log.debug(`Email sent`);
+
+        // Send email to all applicants about opportunity completion
+        await sendEmailToAllApplicants(opportunity, copilotRequest, application.id);


The sendEmailToAllApplicants function call has been modified to remove the req parameter. Ensure that this change is intentional and that the function sendEmailToAllApplicants does not require the req parameter for its execution. If req is needed for logging or other purposes, consider revising the function signature or implementation.

github-actions · 2025-08-18T19:44:04Z

src/routes/copilotOpportunity/delete.js

+      const userIds = applications.map(item => item.userId);
+      const users = await util.getMemberDetailsByUserIds(userIds, req.log, req.id);
+
+      users.forEach(async (user) => {


Consider using Promise.all to handle asynchronous operations within the forEach loop. This ensures that all emails are sent before proceeding, and can help avoid potential issues with unhandled promises.

github-actions · 2025-08-18T19:44:04Z

src/routes/copilotOpportunity/delete.js

+          data: {
+            opportunity_details_url: `${copilotPortalUrl}/opportunity`,
+            opportunity_title: requestData.opportunityTitle,
+            user_name: user ? user.handle : "",


Consider using a default value or handling the case where user.handle might be null or undefined to prevent potential issues with the email content.

github-actions · 2025-08-18T19:44:06Z

src/routes/copilotOpportunity/delete.js

@@ -93,6 +120,8 @@ module.exports = [
          invite.toJSON());
      }

+      await sendEmailToAllApplicants(copilotRequest, applications)


The sendEmailToAllApplicants function call has been modified to remove the req parameter. Ensure that this change does not affect the function's behavior or cause any issues, as the req parameter might have been used within the function for accessing request-specific data.

github-actions · 2025-08-18T21:12:48Z

src/routes/copilotOpportunity/get.js

@@ -4,7 +4,7 @@ import util from '../../util';
 module.exports = [
  (req, res, next) => {
    const { id } = req.params;
-
+    req.log.info("Reached get endpoint");


Consider using a more descriptive log message that includes the opportunity ID to provide better context for debugging, e.g., req.log.info(Reached get endpoint for opportunity ID: ${id});.

github-actions · 2025-08-18T21:12:51Z

src/routes/index.js

@@ -473,6 +473,7 @@ router.use((err, req, res, next) => { // eslint-disable-line no-unused-vars

 // catch 404 and forward to error handler
 router.use((req, res, next) => {
+  req.log.info("reached middleware")


Consider using a more descriptive log message to provide better context for debugging purposes. For example, specify which middleware was reached or the purpose of this log entry.

github-actions · 2025-08-18T21:58:02Z

src/models/copilotRequest.js

@@ -32,6 +32,7 @@ module.exports = function defineCopilotRequest(sequelize, DataTypes) {

  CopliotRequest.associate = (models) => {
    CopliotRequest.hasMany(models.CopilotOpportunity, { as: 'copilotOpportunity', foreignKey: 'copilotRequestId' });
+    CopliotRequest.belongsTo(models.Project, { as: 'project', foreignKey: 'projectId' });


Typo in the model name: CopliotRequest should be CopilotRequest. This typo is present in the existing code as well, but it would be good to correct it to maintain consistency and avoid potential issues.

@hentrymartin please remane and update for the typo. Also, check on all refrences using it.
Funny how we missed this one?

github-actions · 2025-08-18T21:58:07Z

src/routes/copilotRequest/list.js

@@ -15,6 +17,10 @@ module.exports = [
      return next(err);
    }

+    const page = parseInt(req.query.page, 10) || 1;


Consider handling the case where req.query.page is not a valid integer. Currently, parseInt will return NaN for invalid inputs, which could lead to unexpected behavior when calculating offset.

github-actions · 2025-08-18T21:58:07Z

src/routes/copilotRequest/list.js

@@ -15,6 +17,10 @@ module.exports = [
      return next(err);
    }

+    const page = parseInt(req.query.page, 10) || 1;
+    const pageSize = parseInt(req.query.pageSize, 10) || DEFAULT_PAGE_SIZE; 


Similar to the previous comment, ensure that req.query.pageSize is a valid integer before using it. This will prevent potential issues with offset calculation if pageSize is NaN.

github-actions · 2025-08-18T21:58:11Z

src/routes/copilotRequest/list.js

@@ -29,19 +35,22 @@ module.exports = [

    const whereCondition = projectId ? { projectId } : {};

-    return models.CopilotRequest.findAll({
+    return models.CopilotRequest.findAndCountAll({


Consider checking if findAndCountAll is necessary for your use case. If you only need the count for pagination headers, ensure that this change is intentional as it may impact performance.

github-actions · 2025-08-18T21:58:11Z

src/routes/copilotRequest/list.js

-          as: 'copilotOpportunity',
-        },
+        { model: models.CopilotOpportunity, as: 'copilotOpportunity', required: false },
+        { model: models.Project, as: 'project', required: false },


Ensure that the inclusion of the Project model is necessary for the functionality you are implementing. If not, it could lead to unnecessary data fetching.

src/routes/copilotRequest/list.js

github-actions · 2025-08-18T22:50:40Z

src/routes/copilotOpportunity/assign.js

@@ -227,6 +262,9 @@ module.exports = [

      await sendEmailToCopilot();

+      // Send email to all applicants about opportunity completion
+      await sendEmailToAllApplicants(opportunity, copilotRequest, application.id);


Consider handling potential errors that might occur during the execution of sendEmailToAllApplicants. This will ensure that any issues in sending emails do not disrupt the overall flow of the application.

github-actions · 2025-08-18T22:56:45Z

src/routes/copilotOpportunity/assign.js

@@ -32,6 +32,33 @@ module.exports = [
      return next(err);
    }

+    const sendEmailToAllApplicants = async (copilotRequest, allApplications) => {


The function signature of sendEmailToAllApplicants has changed, but the logic for fetching allApplications has been removed. Ensure that allApplications is correctly populated before calling this function, as it is now expected to be passed as an argument.

github-actions · 2025-08-18T22:56:48Z

src/routes/copilotOpportunity/assign.js

@@ -238,6 +265,9 @@ module.exports = [
        transaction: t,
      });

+      // Send email to all applicants about opportunity completion
+      await sendEmailToAllApplicants(copilotRequest, otherApplications);


Consider handling potential errors from the sendEmailToAllApplicants function. If this function fails, it might be beneficial to log the error or take corrective action to ensure the application process continues smoothly.

kkartunov · 2025-08-19T15:55:38Z

src/models/copilotRequest.js

@@ -32,6 +32,7 @@ module.exports = function defineCopilotRequest(sequelize, DataTypes) {

  CopliotRequest.associate = (models) => {
    CopliotRequest.hasMany(models.CopilotOpportunity, { as: 'copilotOpportunity', foreignKey: 'copilotRequestId' });
+    CopliotRequest.belongsTo(models.Project, { as: 'project', foreignKey: 'projectId' });


@hentrymartin please remane and update for the typo. Also, check on all refrences using it.
Funny how we missed this one?

github-actions · 2025-08-19T15:58:28Z

src/models/copilotRequest.js

@@ -30,9 +30,10 @@ module.exports = function defineCopilotRequest(sequelize, DataTypes) {
    indexes: [],
  });

-  CopliotRequest.associate = (models) => {
-    CopliotRequest.hasMany(models.CopilotOpportunity, { as: 'copilotOpportunity', foreignKey: 'copilotRequestId' });
+  CopilotRequest.associate = (models) => {


Typo correction needed: The model name CopliotRequest should be corrected to CopilotRequest.

github-actions · 2025-08-19T15:58:28Z

src/models/copilotRequest.js

  };

-  return CopliotRequest;
+  return CopilotRequest;


Typo correction needed: The model name CopliotRequest should be corrected to CopilotRequest.

kkartunov

@hentrymartin please address all occurances of CopliotRequest in the code base.

hentrymartin · 2025-08-19T16:33:49Z

@hentrymartin please address all occurances of CopliotRequest in the code base.

@kkartunov this is already fixed, somehow, ai buddy points to old version of code.

hentrymartin added 10 commits August 16, 2025 00:17

fix: paginated copilot request

2474181

fix: paginated copilot request

e65a766

fix: paginated copilot request

e439cc8

fix: paginated copilot request

e30591f

fix: paginated copilot request

d4a88f4

fix: add project in copilot request

902e2b3

fix: added project relation to copilot requests

44047b6

feat: send email when opportunity is completed or canceled

e7888e9

feat: send email when opportunity is completed or canceled

4aa668c

feat: send email when opportunity is completed or canceled

83c6db9

github-actions bot reviewed Aug 18, 2025

View reviewed changes

fix: build

5071cb8

github-actions bot reviewed Aug 18, 2025

View reviewed changes

debug

c55231a

github-actions bot reviewed Aug 18, 2025

View reviewed changes

debug

ea6cd97

github-actions bot reviewed Aug 18, 2025

View reviewed changes

fix: assign email

4e0bf89

github-actions bot reviewed Aug 18, 2025

View reviewed changes

fix: assign email

39acdfa

github-actions bot reviewed Aug 18, 2025

View reviewed changes

hentrymartin requested a review from kkartunov August 18, 2025 23:16

removed debug messages

76ec16c

kkartunov requested changes Aug 19, 2025

View reviewed changes

fix: typo

d2425b4

github-actions bot reviewed Aug 19, 2025

View reviewed changes

kkartunov requested changes Aug 19, 2025

View reviewed changes

kkartunov approved these changes Aug 19, 2025

View reviewed changes

hentrymartin merged commit c958c3c into develop Aug 19, 2025
2 checks passed

hentrymartin deleted the pm-1611 branch August 19, 2025 19:16


		const users = await util.getMemberDetailsByUserIds(userIds, req.log, req.id);

		users.forEach(async (user) => {

feat(PM-1611): send email when opportunity is completed or canceled #849

feat(PM-1611): send email when opportunity is completed or canceled #849

Uh oh!

Conversation

hentrymartin commented Aug 18, 2025

What's in this PR?

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

kkartunov Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!