Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --yes option for protonup #560

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Closes #559

@SteveLauC
Copy link
Member Author

cc @dreamcat4, here is a build for x86_64-unknown-linux-musl, you can test it:)

@dreamcat4
Copy link

dreamcat4 commented Sep 30, 2023

ok it seems to work. And here is testing results:

θ64° [id:~/test] [venv] $ ll
total 11M
-rwxrwxr-x 1 id id 11M Sep 30 08:04 topgrade-testbuild.SteveLauC.30-sept-2023.pr560*
lrwxrwxrwx 1 id id  28 Sep 30 09:23 topgrade-v12.0.2 -> /home/id/.cargo/bin/topgrade*


# this was before PR

θ64° [id:~/test] [venv] $ ./topgrade-v12.0.2 --yes --only protonup

── 09:26:23 - protonup ─────────────────────────────────────────────────────────
Ready to download GE-Proton8-16

Size      : 422.6 MiB 
Published : 2023-09-24
Continue? (Y/n): n

── 09:26:27 - Summary ──────────────────────────────────────────────────────────
protonup: OK



# this is with the supplied test build for this PR

θ70° [id:~/test] [venv] $ ./topgrade-testbuild.SteveLauC.30-sept-2023.pr560 --yes --only protonup

── 09:26:36 - protonup ─────────────────────────────────────────────────────────

── 09:28:42 - Summary ──────────────────────────────────────────────────────────
protonup: OK
θ84° [id:~/test] [venv] $ 


# did it update? --> lets try 1st command again

θ68° [id:~/test] [venv] $ ./topgrade-v12.0.2 --yes --only protonup

── 09:29:23 - protonup ─────────────────────────────────────────────────────────
[INFO] GE-Proton8-16 already installed
[INFO] No hotfix found

── 09:29:24 - Summary ──────────────────────────────────────────────────────────
protonup: OK
θ69° [id:~/test] [venv] $ 
θ62° [id:~/test] [venv] $ # TEST SUCCESS

Note: while updating then protonup (when invoked through topgrade) - it did not seem to output any informational statements. So nothing to say it was working, the updating looked "stalled". Or "hung" for a couple of minutes. With not indicators. However the update did occur successfully, upon waiting long enough. And with a discovery afterwards for re-checking again to see no more updates.

@SteveLauC
Copy link
Member Author

ok it seems to work.

Happy to hear this!

Note: while updating then protonup (when invoked through topgrade) - it did not seem to output any informational statements.

I reproduced this on my host, but it seems to be a bug (or feature?) of protonup:

$ protonup
Ready to download GE-Proton8-16
Size      : 422.6 MiB
Published : 2023-09-24
Continue? (Y/n): n

$ protonup --yes
# No output at all

@SteveLauC SteveLauC merged commit a23b761 into topgrade-rs:main Sep 30, 2023
8 checks passed
@SteveLauC SteveLauC deleted the protonup-yes branch September 30, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

topgrade --yes - protonup Continue? (Y/n)
2 participants