Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support VSCodium #788

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented May 6, 2024

This PR adds the support of VSCodium to Topgrade, it is added as an individual step (not an alias of the VSCode step) because:

  1. Users could use both VSCode and VSCoium
  2. Just in case, VSCodium could have incompatible changes with VSCode

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Closes #787

@SteveLauC SteveLauC force-pushed the feat/support_VSCodium_in_step_VSCode branch from f40a037 to 0e31cf7 Compare May 6, 2024 12:38
@SteveLauC SteveLauC mentioned this pull request May 6, 2024
@SteveLauC SteveLauC force-pushed the feat/support_VSCodium_in_step_VSCode branch 2 times, most recently from 424c83c to 5940e0b Compare January 3, 2025 04:33
@topgrade-rs topgrade-rs deleted a comment from codecov bot Jan 3, 2025
@SteveLauC SteveLauC force-pushed the feat/support_VSCodium_in_step_VSCode branch from 18c3228 to 325d9c4 Compare January 3, 2025 04:48
@SteveLauC SteveLauC changed the title feat: support VSCodium in the step VSCode feat: support VSCodium Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support VSCodium
1 participant