Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Add test case for resharing from outside of FROST #36

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

Nashtare
Copy link
Member

Description

This PR adds an integration test for key resharing from an initial, single party that didn't take part in any ICE-FROST key generation process, but who owns a valid keypair for Schnorr signatures.
The resulting individuals' group keys (from the new set) are checked to match the initial public key belonging to the initial party.

This requires an API change to create an IndividualSigningKey from an isolated secret key (i.e. without any DKG indexing).

@Nashtare
Copy link
Member Author

clippy failure is unrelated but caught by latest toolchain, and fixed in linked PR against this branch.

@Nashtare Nashtare requested review from dvdplm and 4l0n50 March 12, 2024 06:17
Nashtare and others added 2 commits March 12, 2024 15:29
…lize()` (#37)

* Fix clippy warning and remove a clone

* Update comment
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Here I also got the answer to the question about the ordering guarantees of signers)

tests/ice_frost.rs Show resolved Hide resolved
Copy link
Member

@4l0n50 4l0n50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just minor comments.

tests/ice_frost.rs Show resolved Hide resolved
tests/ice_frost.rs Show resolved Hide resolved
tests/ice_frost.rs Outdated Show resolved Hide resolved
tests/ice_frost.rs Outdated Show resolved Hide resolved
@Nashtare Nashtare requested a review from a team as a code owner March 27, 2024 14:50
@Nashtare Nashtare merged commit ed205b6 into main Apr 3, 2024
7 checks passed
@Nashtare Nashtare deleted the test-resharing-from-single-party branch April 3, 2024 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants