This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Add test case for resharing from outside of FROST #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clippy failure is unrelated but caught by latest toolchain, and fixed in linked PR against this branch. |
…lize()` (#37) * Fix clippy warning and remove a clone * Update comment
4 tasks
dvdplm
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Here I also got the answer to the question about the ordering guarantees of signers)
4l0n50
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just minor comments.
hratoanina
reviewed
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an integration test for key resharing from an initial, single party that didn't take part in any ICE-FROST key generation process, but who owns a valid keypair for Schnorr signatures.
The resulting individuals' group keys (from the new set) are checked to match the initial public key belonging to the initial party.
This requires an API change to create an
IndividualSigningKey
from an isolated secret key (i.e. without any DKG indexing).