Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failing tests #49

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix: failing tests #49

merged 1 commit into from
Dec 20, 2023

Conversation

JDawg287
Copy link
Member

Description

This PR is made to fix the failing tests added in the previous PRs (#47 & #48)

Fixes TP-816

Please explain in detail which changes are breaking changes in the PR. (If not applicable you can remove this whole section)

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@JDawg287
fix: failing tests
bdf0d2e 
Signed-off-by: Jawad Tariq <[email protected]>
@JDawg287 JDawg287 self-assigned this Dec 19, 2023
@atanmarko atanmarko merged commit 9a32f2e into main Dec 20, 2023
1 check passed
@atanmarko atanmarko deleted the fix/failing-tests branch December 20, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanmarko atanmarko atanmarko approved these changes

Assignees

@JDawg287 JDawg287

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JDawg287 @atanmarko