Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test network long blocks #29

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Sep 13, 2023

Description

Added option for custom block time when starting Polygon Edge, BLOCK_TIME. Default is 2 secods.

Changes include

  • New feature (non-breaking change that adds functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • [] I have tested this code with the official test suite
  • I have tested this code manually

@sebastiendan
Copy link
Member

@atanmarko Why don't we use an env var to dynamically set the block time as we do with other fields, then we don't need an extra init.sh command and we can still set 2s as the default block time.

Copy link

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atanmarko atanmarko merged commit 6949f25 into develop Sep 15, 2023
5 checks passed
@atanmarko atanmarko deleted the feat/test-network-long-blocks branch September 15, 2023 12:20
atanmarko added a commit that referenced this pull request Sep 15, 2023
atanmarko added a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants