feat: add AC to pushCertificate

Signed-off-by: Jawad Tariq <[email protected]>
topos-protocol · Aug 2, 2023 · f840ac6 · f840ac6
1 parent da41ebb
commit f840ac6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/contracts/topos-core/ToposCore.sol b/contracts/topos-core/ToposCore.sol
@@ -67,7 +67,7 @@ contract ToposCore is IToposCore, AdminMultisigBase {
     /// @notice Push the certificate on-chain
     /// @param certBytes The certificate in byte
     /// @param position The position of the certificate
-    function pushCertificate(bytes memory certBytes, uint256 position) external override {
+    function pushCertificate(bytes memory certBytes, uint256 position) external override onlyAdmin {
         (
             CertificateId prevId,
             SubnetId sourceSubnetId,

diff --git a/test/topos-core/ToposCore.test.ts b/test/topos-core/ToposCore.test.ts
@@ -48,6 +48,16 @@ describe('ToposCore', () => {
       ).to.be.revertedWith('Bytes32Set: key already exists in the set.')
     })
 
+    it('reverts if non-admin tries to push certificate', async () => {
+      const { defaultCert, toposCore } = await loadFixture(
+        deployToposCoreFixture
+      )
+      const [, nonAdmin] = await ethers.getSigners()
+      await expect(
+        toposCore.connect(nonAdmin).pushCertificate(defaultCert, cc.CERT_POS_1)
+      ).to.be.revertedWithCustomError(toposCore, 'NotAdmin')
+    })
+
     it('gets the certificate count', async () => {
       const { defaultCert, toposCore } = await loadFixture(
         deployToposCoreFixture