Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rearrange args #105

Merged
merged 1 commit into from
Sep 6, 2023
Merged

chore: rearrange args #105

merged 1 commit into from
Sep 6, 2023

Conversation

JDawg287
Copy link
Member

@JDawg287 JDawg287 commented Sep 6, 2023

Description

This PR refactors the parameters for the sendToken function of the IERC20Messaging interface to match the parameters of the implementation in the ERC20Messaging smart contract

Fixes TP-697

Additions and Changes

  • Changed the order of the parameters of the sendToken function

PR Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@JDawg287 JDawg287 self-assigned this Sep 6, 2023
@JDawg287
chore: rearrange args
5bb524b 
Signed-off-by: Jawad Tariq <[email protected]>
@JDawg287 JDawg287 merged commit f9cfb87 into main Sep 6, 2023
10 checks passed
@JDawg287 JDawg287 deleted the feature/TP-697 branch September 6, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiendan sebastiendan sebastiendan approved these changes

@hadjiszs hadjiszs Awaiting requested review from hadjiszs

Assignees

@JDawg287 JDawg287

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JDawg287 @sebastiendan