Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: use right admin priv key for register subnet script #110

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

sebastiendan
Copy link
Member

@sebastiendan sebastiendan commented Sep 12, 2023

Description

This PR fixes the issue introduced by #107 where a single private key is used both for creating the admin wallet capable of register a new subnet and the new subnet id. To fix this, we introduce a new arg to pass an adminPrivateKey separately from the sequencerPrivateKey.

Passing e2e-tests workflow run

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@sebastiendan sebastiendan merged commit c99fed3 into main Sep 12, 2023
4 of 12 checks passed
@sebastiendan sebastiendan deleted the fix/npm-register-subnet branch September 12, 2023 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant