-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ws endpoint to SubnetRegistrator.sol
#112
Conversation
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
Small detail that can have some degree of importance: I would rename to |
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
Done! |
Nice! Just a note: I didn't mean you should have reordered the function args in an alphabetically ordered list (should looks odd and very uncommon to me). One more thing: Can you open the sibling PR on |
@JDawg287 Here's the green e2e tests ✅ I will merge the PR later today as there's still one thing to update. |
Description
This PR adds an extra WebSocket parameter, for registering a subnet. It is to avoid inferring the WebSocket endpoint from the HTTP endpoint.
BREAKING CHANGES
SubnetRegistrator
'sendpoint
field for subnets has been renamed toendpointHttp
(see more details below)Additions and Changes
endpoint
toendpointHttp
endpointWs
parameter for theregisterSubnet
funcPR Checklist: