Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update topos messaging tests #113

Merged
merged 5 commits into from
Nov 28, 2023
Merged

test: update topos messaging tests #113

merged 5 commits into from
Nov 28, 2023

Conversation

Freyskeyd
Copy link
Member

Description

Update tests in order to remove static and manually generated data fixtures.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd force-pushed the test/TP-778 branch 3 times, most recently from 0075d54 to 176a36d Compare November 10, 2023 16:18
@Freyskeyd Freyskeyd marked this pull request as ready for review November 21, 2023 07:13
test/topos-core/ToposMessaging.test.ts Outdated Show resolved Hide resolved
test/topos-core/ToposMessaging.test.ts Outdated Show resolved Hide resolved
@JDawg287
Copy link
Member

@Freyskeyd We are still missing the fixes for the final test which are supposed to be in the same PR.
That would be the reverts if trying to mint for zero address test.

Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
@JDawg287 JDawg287 merged commit a23783e into main Nov 28, 2023
10 checks passed
@JDawg287 JDawg287 deleted the test/TP-778 branch November 28, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants