Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: remove check for existing tokens #114

Merged
merged 1 commit into from
Nov 22, 2023
Merged

chore: remove check for existing tokens #114

merged 1 commit into from
Nov 22, 2023

Conversation

JDawg287
Copy link
Member

@JDawg287 JDawg287 commented Nov 13, 2023

Description

This PR removes the check for External ERC20 token addresses when deploying an ERC20 token via the Topos Cross-Subnet Messaging Protocol.
Only Internal tokens are allowed to be deployed.

Fixes TP-782

Additions and Changes

  • Removed the address param from the input params for the sendToken method in ERC20Messaging.sol smart contract
  • Adapted the unit tests to the changes

Breaking Changes

Changes the input params for the deployToken function so will require changes to the infra as well

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@JDawg287 JDawg287 self-assigned this Nov 13, 2023
@sebastiendan
Copy link
Member

Passing CI with the related Frontend update
https://github.com/topos-protocol/e2e-tests/actions/runs/6958443031

@JDawg287 JDawg287 merged commit a583a5f into main Nov 22, 2023
23 of 24 checks passed
@JDawg287 JDawg287 deleted the feature/TP-782 branch November 22, 2023 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants