Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump package-lock.json version to v3.1.0 #121

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

JDawg287
Copy link
Member

Description

Bumps the package-lock.json ver to match the package.lock ver

v3.0.0 -> v3.1.0

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@sebastiendan
Copy link
Member

@JDawg287 This update is an outcome of an npm install, right?

@JDawg287
Copy link
Member Author

@JDawg287 This update is an outcome of an npm install, right?

@sebastiendan I thought it was a left-out.
I usually do npm ci so as not to get diffs in the package-lock.json file.

@sebastiendan
Copy link
Member

@JDawg287 This update is an outcome of an npm install, right?

@sebastiendan I thought it was a left-out. I usually do npm ci so as not to get diffs in the package-lock.json file.

No I meant: Did you change that value in the lock file yourself manually, or did you run an npm install to have it? You shouldn't change a lock file by hand, an npm install will update update it according to package.json.

@JDawg287
Copy link
Member Author

@JDawg287 This update is an outcome of an npm install, right?

@sebastiendan I thought it was a left-out. I usually do npm ci so as not to get diffs in the package-lock.json file.

No I meant: Did you change that value in the lock file yourself manually, or did you run an npm install to have it? You shouldn't change a lock file by hand, an npm install will update update it according to package.json.

Ah yea, once I noticed, I ran the npm i command and then the lock file was changed accordingly.

@JDawg287 JDawg287 merged commit 08562b0 into main Jan 29, 2024
10 checks passed
@JDawg287 JDawg287 deleted the chore/bump-lock-v3.1.0 branch January 29, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants