Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat(p2p/tce): add gossipsub message_id to tce logs #488

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Freyskeyd
Copy link
Member

Description

To better understand the flow of a message on the network, we expose the MessageId generated during the GossipSub publication of GOSSIP|ECHO|READY message.
This message_id will then be placed in every related logs as metadata in order to filter on them in dashboard for exploration.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner March 29, 2024 08:58
@Freyskeyd Freyskeyd force-pushed the feature/track-message-id-gossipsub branch from 12f667b to 40b7fc3 Compare March 29, 2024 09:46
@Freyskeyd Freyskeyd force-pushed the feature/track-message-id-gossipsub branch from 40b7fc3 to b1a3714 Compare March 29, 2024 09:50
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 58.53659% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 72.02%. Comparing base (b8cd730) to head (7b34909).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/topos-tce/src/app_context/network.rs 19.60% 41 Missing ⚠️
crates/topos-tce/src/app_context/protocol.rs 38.88% 11 Missing ⚠️
...es/topos-p2p/src/runtime/handle_event/gossipsub.rs 64.28% 10 Missing ⚠️
crates/topos-tce/src/tests/mod.rs 84.61% 4 Missing ⚠️
crates/topos-p2p/src/behaviour/gossip.rs 95.45% 1 Missing ⚠️
crates/topos-p2p/src/client.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   72.21%   72.02%   -0.20%     
==========================================
  Files         219      219              
  Lines       12829    12867      +38     
==========================================
+ Hits         9265     9267       +2     
- Misses       3564     3600      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd force-pushed the feature/track-message-id-gossipsub branch from a473cae to d501785 Compare April 1, 2024 08:57
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd force-pushed the feature/track-message-id-gossipsub branch from d501785 to 836c39a Compare April 2, 2024 06:45
Signed-off-by: Simon Paitrault <[email protected]>
@hadjiszs hadjiszs removed their request for review May 24, 2024 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant