Skip to content

Commit

Permalink
Upgrade to Node v20
Browse files Browse the repository at this point in the history
  • Loading branch information
vedrani committed Dec 16, 2024
1 parent 54f3447 commit 4e34354
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 22 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
pull_request:
branches:
- master # triggers the flow for every PR to master
- "feature/**" # triggers the flow for a PR to a branch like feature/v9
- 'feature/**' # triggers the flow for a PR to a branch like feature/v9

types:
- synchronize # PR was updated
Expand Down Expand Up @@ -128,7 +128,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Check missing changeset
uses: toptal/davinci-github-actions/[email protected]
Expand Down Expand Up @@ -203,7 +203,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Install dependencies from cache
uses: toptal/davinci-github-actions/[email protected]
Expand Down Expand Up @@ -294,7 +294,7 @@ jobs:
"BRANCH": "${{ env.BRANCH }}",
"PR_ID": "${{ env.PR_ID }}"
}
job_timeout: "3600"
job_timeout: '3600'

- name: Create Jira Deployment
uses: ./.github/actions/create-jira-deployment/
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/danger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- uses: toptal/davinci-github-actions/[email protected]

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/davinci-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- uses: toptal/davinci-github-actions/[email protected]

Expand All @@ -64,7 +64,7 @@ jobs:
- name: Cache built packages
uses: actions/cache@v3
with:
path: "packages/**/dist-package"
path: 'packages/**/dist-package'
key: ${{ runner.os }}-pkgs-${{ github.run_id }} }}

integration-tests:
Expand Down Expand Up @@ -113,14 +113,14 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- uses: toptal/davinci-github-actions/[email protected]

- name: Get cached packages
uses: actions/cache@v3
with:
path: "packages/**/dist-package"
path: 'packages/**/dist-package'
key: ${{ runner.os }}-pkgs-${{ github.run_id }} }}

- name: Run integration tests
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- uses: toptal/davinci-github-actions/[email protected]

Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -190,7 +190,7 @@ jobs:
{
"COMMIT_ID": "${{ github.sha }}"
}
job_timeout: "7200"
job_timeout: '7200'

- name: Send a Slack notification on failure
if: ${{ failure() }}
Expand All @@ -200,24 +200,24 @@ jobs:
FAILURE_URL: ${{ steps.trigger-deploy.outputs.jenkins_job_url || steps.trigger-build.outputs.jenkins_job_url }}
FALLBACK_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}?check_suite_focus=true
with:
channel-id: "-frontend-exp-team-notifications"
slack-message: ":x: <!here> Current master version of Picasso is <${{ env.FAILURE_URL || env.FALLBACK_URL }}|broken>."
channel-id: '-frontend-exp-team-notifications'
slack-message: ':x: <!here> Current master version of Picasso is <${{ env.FAILURE_URL || env.FALLBACK_URL }}|broken>.'

- name: Send a Slack notification on success release
if: ${{ success() && steps.changesets.outputs.published == 'true' }}
uses: slackapi/[email protected]
with:
channel-id: "-frontend-exp-team-notifications"
slack-message: "Current master version of Picasso successfully released :green_heart:"
channel-id: '-frontend-exp-team-notifications'
slack-message: 'Current master version of Picasso successfully released :green_heart:'
env:
SLACK_BOT_TOKEN: ${{ env.SLACK_BOT_TOKEN }}

- name: Send a Slack notification on success PR merge
if: ${{ success() && steps.changesets.outputs.published != 'true'}}
uses: slackapi/[email protected]
with:
channel-id: "-frontend-exp-team-notifications"
slack-message: "A new PR was merged to Picasso :parrotspin:"
channel-id: '-frontend-exp-team-notifications'
slack-message: 'A new PR was merged to Picasso :parrotspin:'
env:
SLACK_BOT_TOKEN: ${{ env.SLACK_BOT_TOKEN }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/visual-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- uses: toptal/davinci-github-actions/[email protected]

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1
FROM node:18-alpine
FROM node:20-alpine

ENV PATH="${PATH}:/app/node_modules/.bin" \
# Installs Chromium (77) package.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@
"zx": "^8.0.2"
},
"engines": {
"node": ">=18"
"node": ">=20"
},
"files": [
"src"
Expand Down
2 changes: 1 addition & 1 deletion packages/picasso-codemod/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@
"src"
],
"engines": {
"node": ">=18"
"node": ">=20"
}
}

0 comments on commit 4e34354

Please sign in to comment.