[FX-4737] Do not pass enableResetSearch property

[sashuk]

FX-4737

Description

This pull request fixes the bug with passed enableResetSearch prop, introduced in #4075.

Reason – spread operator is not type safe in this case (packages/picasso/src/NativeSelect/NativeSelect.tsx)

No type check using spread operator (no error detected)

Normal typescheck when passing prop directly (error is detected)

How to test

• Temploy
• Tests pass when alpha package is applied in Staff Portal in (please check out https://github.com/toptal/staff-portal/pull/11832 locally and run yarn test namespaces/jobs/libs/jobs/src/containers/SendJobAwayModal/test.tsx)
• Another error in Staff Portal Jest tests that appears is fixed in https://toptal-core.atlassian.net/browse/FX-4727

Development checks

• Add changeset according to guidelines (if needed)
• Read CONTRIBUTING.md and Component API principles
• Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
• [N/A] Annotate all props in component with documentation
• [N/A] Create examples for component
• Ensure that deployed demo has expected results and good examples
• [N/A] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
• Self reviewed
• [N/A] Covered with tests (visual tests included)
• ⚠️ Delete https://github.com/toptal/staff-portal/pull/11832 before merge

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

• @toptal-bot run package:alpha-release - Release alpha version
• @toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

1. You have no extra requests.
2. You have optional requests.
   1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

1. Something is broken after the changes.
2. Acceptance criteria is not reached.
3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

1. There are leftovers like unnecessary logs, comments, etc.
2. You have an opinionated comment regarding the code that requires a discussion.
3. You have questions.

How to handle the comments?

1. An owner of a comment is the only one who can resolve it.
2. An owner of a comment must resolve it when it's addressed.
3. A PR owner must reply with ✅ when a comment is addressed.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0ee49b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@toptal/picasso	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[sashuk]

@toptal-bot run package:alpha-release

[toptal-devbot]

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.41+e1f0cf25f
yarn add @toptal/[email protected]+e1f0cf25f
yarn add @toptal/picasso-charts@56.0.2-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.5+e1f0cf25f
yarn add @toptal/picasso-codemod@5.6.4-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.91+e1f0cf25f
yarn add @toptal/picasso-forms@66.1.3-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.5+e1f0cf25f
yarn add @toptal/picasso-pictograms@2.0.1-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.161+e1f0cf25f
yarn add @toptal/picasso-provider@3.4.3-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.33+e1f0cf25f
yarn add @toptal/picasso-query-builder@1.3.1-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.7+e1f0cf25f
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.41+e1f0cf25f
yarn add @toptal/picasso-shared@13.1.3-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.14+e1f0cf25f
yarn add @toptal/picasso-tailwind@1.0.2-alpha-FX-NULL-fix-passing-of-property-e1f0cf25f.21+e1f0cf25f

[sashuk]

@toptal-anvil ping reviewers

[rasitozcan]

Is that normal that it passed CI checks, when enableResetSearch prop is added?

[sashuk]

@rasitozcan I think there is a problem somewhere in types of MUINativeSelect or the way Typescript handles types of spread operator, so for now we fix the problem in master and then should be a proper research as we might have other places with this problem.