Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5817] Version update of picasso-tailwind-merge #4500

Merged
merged 10 commits into from
Aug 23, 2024

Conversation

ruslan-sed
Copy link
Contributor

@ruslan-sed ruslan-sed commented Aug 22, 2024

FX-5817

Description

In this PR we are making a major update of picasso-tailwind-merge because we missed to do it before. We also introduce tests and README to prevent it in the future.

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Development checks

Breaking change

  • ~codemod is created and showcased in the changeset
  • ~test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@ruslan-sed ruslan-sed self-assigned this Aug 22, 2024
Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 18b17f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 72 packages
Name Type
@toptal/picasso-account-select Major
@toptal/picasso-autocomplete Major
@toptal/picasso-avatar Major
@toptal/picasso-avatar-upload Major
@toptal/picasso-badge Major
@toptal/picasso-breadcrumbs Major
@toptal/picasso-button Major
@toptal/picasso-calendar Major
@toptal/picasso-carousel Major
@toptal/picasso-checkbox Major
@toptal/picasso-collapse Major
@toptal/picasso-container Major
@toptal/picasso-dropdown Major
@toptal/picasso-dropzone Major
@toptal/picasso-environment-banner Major
@toptal/picasso-form Major
@toptal/picasso-grid Major
@toptal/picasso-helpbox Major
@toptal/picasso-image Major
@toptal/picasso-input-adornment Major
@toptal/picasso-link Major
@toptal/picasso-loader Major
@toptal/picasso-menu Major
@toptal/picasso-note Major
@toptal/picasso-notification Major
@toptal/picasso-number-input Major
@toptal/picasso-outlined-input Major
@toptal/picasso-overview-block Major
@toptal/picasso-page Major
@toptal/picasso-pagination Major
@toptal/picasso-paper Major
@toptal/picasso-password-input Major
@toptal/picasso-radio Major
@toptal/picasso-section Major
@toptal/picasso-select Major
@toptal/picasso-slider Major
@toptal/picasso-step Major
@toptal/picasso-table Major
@toptal/picasso-tag Major
@toptal/picasso-timepicker Major
@toptal/picasso-typography Major
@toptal/picasso-rich-text-editor Major
@toptal/picasso-tailwind-merge Major
@toptal/picasso Patch
@toptal/picasso-forms Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-user-badge Major
@toptal/picasso-query-builder Patch
@toptal/picasso-accordion Patch
@toptal/picasso-alert Patch
@toptal/picasso-application-update-notification Patch
@toptal/picasso-drawer Patch
@toptal/picasso-file-input Patch
@toptal/picasso-modal Patch
@toptal/picasso-prompt-modal Patch
@toptal/picasso-show-more Patch
@toptal/picasso-skeleton-loader Patch
@toptal/picasso-tree-view Patch
@toptal/picasso-date-picker Patch
@topkit/analytics-charts Patch
@toptal/picasso-empty-state Patch
@toptal/picasso-input Patch
@toptal/picasso-list Patch
@toptal/picasso-quote Patch
@toptal/picasso-rating Patch
@toptal/picasso-tabs Patch
@toptal/picasso-timeline Patch
@toptal/picasso-switch Patch
@toptal/picasso-date-select Patch
@toptal/picasso-amount Patch
@toptal/picasso-tooltip Patch
@toptal/picasso-typography-overflow Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ruslan-sed ruslan-sed force-pushed the fx-5817-picasso-tailwind-merge-version-update branch 3 times, most recently from 6374c5b to 1afb31b Compare August 22, 2024 15:26
Copy link
Contributor

@dmaklygin dmaklygin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@ruslan-sed ruslan-sed force-pushed the fx-5817-picasso-tailwind-merge-version-update branch from b1e6fef to 65d8c21 Compare August 23, 2024 07:34
@ruslan-sed ruslan-sed marked this pull request as ready for review August 23, 2024 08:01
@ruslan-sed ruslan-sed requested a review from a team August 23, 2024 08:01
@ruslan-sed
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for taking care of this

@ruslan-sed ruslan-sed force-pushed the fx-5817-picasso-tailwind-merge-version-update branch from a0d3e78 to 18b17f1 Compare August 23, 2024 09:49
@ruslan-sed ruslan-sed enabled auto-merge (squash) August 23, 2024 10:06
@ruslan-sed ruslan-sed merged commit 3ed8c02 into master Aug 23, 2024
18 checks passed
@ruslan-sed ruslan-sed deleted the fx-5817-picasso-tailwind-merge-version-update branch August 23, 2024 10:33
@toptal-build toptal-build mentioned this pull request Aug 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants