Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPT-2535] Add property to place accordion icon on the left #4522

Conversation

angelinastavniiciuc
Copy link
Contributor

@angelinastavniiciuc angelinastavniiciuc commented Sep 3, 2024

CPT-2535

Description

While working on Call Assistant modal there was a design where expand Accordion button is placed to the left, there was no possibility to add it via Picasso so we implemented workaround solution. In this PR we added this prop and provided an example for it.

How to test

  • Temploy
  • Open Picasso Accordion on Temploy
  • Check Expand Icon Placement example
  • Make sure that the icon is placed to the left

Screenshots

After.
Screenshot from 2024-09-03 17-19-46

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • n/a codemod is created and showcased in the changeset
  • n/a test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@angelinastavniiciuc angelinastavniiciuc self-assigned this Sep 3, 2024
@angelinastavniiciuc angelinastavniiciuc requested a review from a team September 3, 2024 14:28
Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: 9ea5407

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@toptal/picasso-accordion Minor
@toptal/picasso Patch
@toptal/picasso-page Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal-devbot toptal-devbot added the contribution DO NOT ADD MANUALLY label Sep 3, 2024
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @angelinastavniiciuc 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@angelinastavniiciuc angelinastavniiciuc requested a review from a team September 3, 2024 14:29
@angelinastavniiciuc
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelinastavniiciuc Can you please confirm that Design Team approved this change? Is there a Figma or https://toptal.enterprise.slack.com/archives/CCC3GP6CC discussion for this decision?

Can you please also check why visual changes affect existing stories, can it be avoided?

@toptalwadiibasmi
Copy link
Contributor

toptalwadiibasmi commented Sep 3, 2024

@angelinastavniiciuc Can you please confirm that Design Team approved this change? Is there a Figma or https://toptal.enterprise.slack.com/archives/CCC3GP6CC discussion for this decision?

Can you please also check why visual changes affect existing stories? Can they be avoided?

Hello @sashuk, we created this ticket because we had to work around it in the Staff portal / Call assistant to place the accordion arrow on the left. It worked by overriding the styles.

  1. The changes are supposed not to affect existing styles.
  2. We did not open a conversation with the Design team, nor a figma designed specifically for Picasso component; however, you can find the accordion arrow placed on the left here: https://www.figma.com/design/ZQYgv6RusbmakdzxLEkeHx/Call-Assistant?node-id=5521-79029&node-type=FRAME&t=91POMFybF2sZQw8O-0
  3. The goal is to propose a minor feature to do that via a property without causing any breaking changes to existing functionality.

What do you think?

@sashuk
Copy link
Contributor

sashuk commented Sep 3, 2024

Hello, @toptalwadiibasmi! Let's double check with Design Team here, as the designs that Picasso is supposed to follow do not have this case

@angelinastavniiciuc
Copy link
Contributor Author

@angelinastavniiciuc Can you please confirm that Design Team approved this change? Is there a Figma or https://toptal.enterprise.slack.com/archives/CCC3GP6CC discussion for this decision?

Can you please also check why visual changes affect existing stories, can it be avoided?

Hey @sashuk yep I asked design team for feedback about this change and they confirmed it, here is the thread https://toptal-core.slack.com/archives/C02AN1SSGK0/p1725363298979669
about visual checks changes will check and will update the PR !

@angelinastavniiciuc angelinastavniiciuc force-pushed the CPT-2535-add-property-to-place-picasso-accordion-icon-on-the-left branch from cbbb8e1 to 69dd83e Compare September 4, 2024 09:42
@sashuk
Copy link
Contributor

sashuk commented Sep 4, 2024

Thank you @angelinastavniiciuc for checking!

Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only visual addition is approved

@angelinastavniiciuc
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@toptalwadiibasmi toptalwadiibasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

@karlavdelgadof karlavdelgadof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved ✅

@angelinastavniiciuc angelinastavniiciuc force-pushed the CPT-2535-add-property-to-place-picasso-accordion-icon-on-the-left branch from 3c0b05f to 9ea5407 Compare September 4, 2024 13:05
@angelinastavniiciuc angelinastavniiciuc merged commit 34f55d4 into master Sep 4, 2024
18 checks passed
@angelinastavniiciuc angelinastavniiciuc deleted the CPT-2535-add-property-to-place-picasso-accordion-icon-on-the-left branch September 4, 2024 13:28
@toptal-build toptal-build mentioned this pull request Sep 4, 2024
1 task
angelinastavniiciuc added a commit that referenced this pull request Sep 5, 2024
…4526)

* Revert "[CPT-2535] Add property to place accordion icon on the left (#4522)"

This reverts commit 34f55d4.

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants