Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF-] Debug toptal actions #4702

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

[FF-] Debug toptal actions #4702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
58db393
Transform styles from JSS to TW
vedrani Mar 10, 2025
bd51386
Update snapshots
vedrani Mar 10, 2025
9377992
Add changeset
vedrani Mar 10, 2025
e8f41ad
Fix
vedrani Mar 11, 2025
59a08d1
Fix
vedrani Mar 11, 2025
2753910
Fix
vedrani Mar 11, 2025
08cf221
Fix CI
vedrani Mar 12, 2025
556e7d7
Fix CI
vedrani Mar 12, 2025
1f03599
Fix CI
vedrani Mar 12, 2025
2530714
Fix CI
vedrani Mar 12, 2025
ab6251a
Fix CI
vedrani Mar 12, 2025
01928a1
Fix CI
vedrani Mar 12, 2025
b7b0a9d
Fix CI
vedrani Mar 12, 2025
52c8ba6
Fix CI
vedrani Mar 12, 2025
1041251
Fix CI
vedrani Mar 12, 2025
268b4d0
Fix CI
vedrani Mar 12, 2025
07fdcd4
Fix CI
vedrani Mar 12, 2025
64907f4
Fix CI
vedrani Mar 12, 2025
43b40f3
Fix
vedrani Mar 14, 2025
dc61bcc
Fix
vedrani Mar 14, 2025
a1cee3a
Fix
vedrani Mar 14, 2025
f249894
Fix
vedrani Mar 14, 2025
5b64bd3
Use access_token
vedrani Mar 14, 2025
bd6f097
Fix
vedrani Mar 14, 2025
be6695d
Debug
vedrani Mar 14, 2025
e87c5c8
Debug
vedrani Mar 14, 2025
dd5be54
Debug
vedrani Mar 14, 2025
9498d8c
Debug
vedrani Mar 14, 2025
9f4e36a
Debug
vedrani Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/nasty-bats-clean.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@toptal/picasso-page': patch
---

### SidebarItemContent

- migrate SidebarItemContent styles from JSS to Tailwind
54 changes: 36 additions & 18 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
pull_request:
branches:
- master # triggers the flow for every PR to master
- "feature/**" # triggers the flow for a PR to a branch like feature/v9
- 'feature/**' # triggers the flow for a PR to a branch like feature/v9

types:
- synchronize # PR was updated
Expand Down Expand Up @@ -35,7 +35,7 @@ jobs:

- name: GSM Secrets
id: secrets_manager
uses: toptal/davinci-github-actions/gsm-secrets@v15.4.1
uses: toptal/davinci-github-actions/gsm-secrets@FF-davinci-gha-add-wif
with:
workload_identity_provider: ${{ secrets.IDENTITY_POOL }}
service_account: ${{ secrets.SA_IDENTITY_POOL }}
Expand All @@ -53,7 +53,7 @@ jobs:

- name: Parse secrets
id: parse_secrets
uses: toptal/davinci-github-actions/expose-json-outputs@v15.4.1
uses: toptal/davinci-github-actions/expose-json-outputs@v17.1.0
with:
json: ${{ steps.secrets_manager.outputs.secrets }}

Expand All @@ -74,7 +74,7 @@ jobs:
echo 'EOF' >> $GITHUB_ENV
echo "TOPTAL_DEVBOT_TOKEN=${{ steps.parse_secrets.outputs.TOPTAL_DEVBOT_TOKEN }}" >> $GITHUB_ENV

- uses: toptal/davinci-github-actions/build-push-image@v15.4.1
- uses: toptal/davinci-github-actions/build-push-image@v17.1.0
with:
sha: ${{ github.event.pull_request.head.sha }}
image-name: picasso
Expand All @@ -98,7 +98,7 @@ jobs:

- name: GSM Secrets
id: secrets_manager
uses: toptal/davinci-github-actions/gsm-secrets@v15.4.1
uses: toptal/davinci-github-actions/gsm-secrets@FF-davinci-gha-add-wif
with:
workload_identity_provider: ${{ secrets.IDENTITY_POOL }}
service_account: ${{ secrets.SA_IDENTITY_POOL }}
Expand All @@ -112,7 +112,7 @@ jobs:

- name: Parse secrets
id: parse_secrets
uses: toptal/davinci-github-actions/expose-json-outputs@v15.4.1
uses: toptal/davinci-github-actions/expose-json-outputs@v17.1.0
with:
json: ${{ steps.secrets_manager.outputs.secrets }}

Expand All @@ -131,7 +131,7 @@ jobs:
node-version: 20

- name: Check missing changeset
uses: toptal/davinci-github-actions/report-missing-changeset@v15.4.1
uses: toptal/davinci-github-actions/report-missing-changeset@v17.1.0
with:
github-token: ${{ env.TOPTAL_DEVBOT_TOKEN }}

Expand Down Expand Up @@ -177,7 +177,7 @@ jobs:

- name: GSM Secrets
id: secrets_manager
uses: toptal/davinci-github-actions/gsm-secrets@v15.4.1
uses: toptal/davinci-github-actions/gsm-secrets@FF-davinci-gha-add-wif
with:
workload_identity_provider: ${{ secrets.IDENTITY_POOL }}
service_account: ${{ secrets.SA_IDENTITY_POOL }}
Expand All @@ -189,7 +189,7 @@ jobs:

- name: Parse secrets
id: parse_secrets
uses: toptal/davinci-github-actions/expose-json-outputs@v15.4.1
uses: toptal/davinci-github-actions/expose-json-outputs@v17.1.0
with:
json: ${{ steps.secrets_manager.outputs.secrets }}

Expand Down Expand Up @@ -231,9 +231,12 @@ jobs:
id-token: write
needs: [build-docker-image]
steps:
- name: Checkout
uses: actions/checkout@v4

- name: GSM Secrets
id: secrets_manager
uses: toptal/davinci-github-actions/gsm-secrets@v15.4.1
uses: toptal/davinci-github-actions/gsm-secrets@FF-davinci-gha-add-wif
with:
workload_identity_provider: ${{ secrets.IDENTITY_POOL }}
service_account: ${{ secrets.SA_IDENTITY_POOL }}
Expand All @@ -251,7 +254,7 @@ jobs:

- name: Parse secrets
id: parse_secrets
uses: toptal/davinci-github-actions/expose-json-outputs@v15.4.1
uses: toptal/davinci-github-actions/expose-json-outputs@v17.1.0
with:
json: ${{ steps.secrets_manager.outputs.secrets }}

Expand All @@ -264,21 +267,36 @@ jobs:
echo "JENKINS_USER=${{ steps.parse_secrets.outputs.TOPTAL_TRIGGERBOT_USERNAME }}" >> $GITHUB_ENV
echo "JENKINS_TOKEN=${{ steps.parse_secrets.outputs.TOPTAL_TRIGGERBOT_TOKEN }}" >> $GITHUB_ENV

- name: Debug Authentication Setup
run: |
echo "Checking if Jenkins credentials are available"
if [ -n "$JENKINS_USER" ] && [ -n "$JENKINS_TOKEN" ]; then
echo "Jenkins credentials are set"
else
echo "Jenkins credentials are missing"
fi

if [ -n "${{ steps.secrets_manager.outputs.access_token }}" ]; then
echo "Access token from GSM Secrets is available"
else
echo "Access token from GSM Secrets is not available"
fi

- name: Get toptal/actions
uses: actions/checkout@v4
with:
repository: toptal/actions
token: ${{ steps.parse_secrets.outputs.TOPTAL_REPOACCESSBOT_TOKEN }}
path: ./.github/actions/

- name: Replace toptal/actions/get-job-url@main from trigger-jenkins-job/action.yml
- name: Replace toptal/actions/get-job-url@v1.0.2 from trigger-jenkins-job/action.yml
shell: bash
run: |
sed -i 's|toptal/actions/get-job-url@main|./.github/actions/get-job-url|' ./.github/actions/trigger-jenkins-job/action.yml
sed -i 's|toptal/actions/trigger-jenkins-job@main|./.github/actions/trigger-jenkins-job|' ./.github/actions/create-jira-deployment/action.yml
sed -i 's|toptal/actions/get-job-url@v1.0.2|./.github/actions/get-job-url|' ./.github/actions/trigger-jenkins-job/action.yml
sed -i 's|toptal/actions/trigger-jenkins-job@v1.0.2|./.github/actions/trigger-jenkins-job|' ./.github/actions/create-jira-deployment/action.yml

- name: Trigger doc deployment job
uses: ./.github/actions/trigger-jenkins-job/
uses: toptal/actions/trigger-jenkins-job@v1.0.4
env:
BRANCH: ${{ github.event.pull_request.head.ref }}
PR_ID: ${{ github.event.pull_request.number }}
Expand All @@ -287,14 +305,14 @@ jobs:
jenkins_user: ${{ steps.parse_secrets.outputs.TOPTAL_TRIGGERBOT_USERNAME }}
jenkins_token: ${{ steps.parse_secrets.outputs.TOPTAL_TRIGGERBOT_TOKEN }}
jenkins_client_id: ${{ steps.parse_secrets.outputs.JENKINS_CLIENT_ID }}
jenkins_sa_credentials: ${{ steps.parse_secrets.outputs.JENKINS_SA_CREDENTIALS }}
wif_token: ${{ steps.secrets_manager.outputs.access_token }}
job_name: picasso-docs
job_params: |
{
"BRANCH": "${{ env.BRANCH }}",
"PR_ID": "${{ env.PR_ID }}"
}
job_timeout: "3600"
job_timeout: '3600'

- name: Create Jira Deployment
uses: ./.github/actions/create-jira-deployment/
Expand All @@ -304,7 +322,7 @@ jobs:
jenkins_user: ${{ steps.parse_secrets.outputs.TOPTAL_TRIGGERBOT_USERNAME }}
jenkins_token: ${{ steps.parse_secrets.outputs.TOPTAL_TRIGGERBOT_TOKEN }}
jenkins_client_id: ${{ steps.parse_secrets.outputs.JENKINS_CLIENT_ID }}
jenkins_sa_credentials: ${{ steps.parse_secrets.outputs.JENKINS_SA_CREDENTIALS }}
wif_token: ${{ steps.secrets_manager.outputs.access_token }}
token: ${{ env.TOPTAL_DEVBOT_TOKEN }}
environment: staging
environment-url: ${{ steps.temploy.outputs.temployURL }}
Expand Down
44 changes: 22 additions & 22 deletions packages/base/Page/src/SidebarItem/__snapshots__/test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ exports[`SidebarItem collapsible menu is expanded when one of the children is se
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<div
class="items-center flex PicassoSidebarItemContent-noWrap"
class="items-center flex flex-1 min-w"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -115,10 +115,10 @@ exports[`SidebarItem collapsible menu is expanded when one of the children is se
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<div
class="items-center flex PicassoSidebarItemContent-noWrap"
class="items-center flex flex-1 min-w"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -197,10 +197,10 @@ exports[`SidebarItem collapsible menu is expanded when one of the children is se
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<div
class="items-center flex PicassoSidebarItemContent-noWrap"
class="items-center flex flex-1 min-w"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -261,10 +261,10 @@ exports[`SidebarItem collapsible menu is expanded when one of the children is se
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<div
class="items-center flex PicassoSidebarItemContent-noWrap"
class="items-center flex flex-1 min-w"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -313,7 +313,7 @@ exports[`SidebarItem don't use accordion for non-collapsible with menu 1`] = `
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<svg
class="PicassoSvgCandidates16-root"
Expand All @@ -325,7 +325,7 @@ exports[`SidebarItem don't use accordion for non-collapsible with menu 1`] = `
/>
</svg>
<div
class="items-center flex PicassoSidebarItemContent-noWrap PicassoSidebarItemContent-withIcon"
class="items-center flex flex-1 min-w ml-[.375rem]"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -360,10 +360,10 @@ exports[`SidebarItem don't use accordion for non-collapsible with menu 1`] = `
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<div
class="items-center flex PicassoSidebarItemContent-noWrap"
class="items-center flex flex-1 min-w"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -403,7 +403,7 @@ exports[`SidebarItem is selected 1`] = `
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<svg
class="PicassoSvgCandidates16-root"
Expand All @@ -415,7 +415,7 @@ exports[`SidebarItem is selected 1`] = `
/>
</svg>
<div
class="items-center flex PicassoSidebarItemContent-noWrap PicassoSidebarItemContent-withIcon"
class="items-center flex flex-1 min-w ml-[.375rem]"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -453,10 +453,10 @@ exports[`SidebarItem renders 1`] = `
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<div
class="items-center flex PicassoSidebarItemContent-noWrap"
class="items-center flex flex-1 min-w"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -507,7 +507,7 @@ exports[`SidebarItem use accordion for collapsible with menu 1`] = `
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<svg
class="PicassoSvgCandidates16-root"
Expand All @@ -519,7 +519,7 @@ exports[`SidebarItem use accordion for collapsible with menu 1`] = `
/>
</svg>
<div
class="items-center flex PicassoSidebarItemContent-noWrap PicassoSidebarItemContent-withIcon"
class="items-center flex flex-1 min-w ml-[.375rem]"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -580,10 +580,10 @@ exports[`SidebarItem use accordion for collapsible with menu 1`] = `
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<div
class="items-center flex PicassoSidebarItemContent-noWrap"
class="items-center flex flex-1 min-w"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down Expand Up @@ -628,7 +628,7 @@ exports[`SidebarItem with icon 1`] = `
class="flex items-center"
>
<div
class="gap-2 items-center inline-flex PicassoSidebarItemContent-noWrap"
class="gap-2 items-center inline-flex flex-1 min-w"
>
<svg
class="PicassoSvgCandidates16-root"
Expand All @@ -640,7 +640,7 @@ exports[`SidebarItem with icon 1`] = `
/>
</svg>
<div
class="items-center flex PicassoSidebarItemContent-noWrap PicassoSidebarItemContent-withIcon"
class="items-center flex flex-1 min-w ml-[.375rem]"
>
<p
class="m-0 text-md text-inherit font-regular whitespace-nowrap overflow-ellipsis overflow-hidden"
Expand Down
Loading
Loading