Assign default_html to None, return empty string if default_html is N…

…one, get rid of hard failure
torchbox · Jan 23, 2024 · befce00 · befce00
1 parent 829f7ac
commit befce00
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/pattern_library/monkey_utils.py b/pattern_library/monkey_utils.py
@@ -15,7 +15,7 @@
 def override_tag(
     register: django.template.Library,
     name: str,
-    default_html: typing.Optional[typing.Any] = UNSPECIFIED,
+    default_html: typing.Optional[typing.Any] = None,
 ):
     """
     An utility that helps you override original tags for use in your pattern library.
@@ -95,14 +95,15 @@ def node_render(context):
                                 Warning,
                             )
                         else:
-                            raise TypeError(
+                            warnings.warn(
                                 'default_html argument to override_tag must be a string (line %s in "%s")'
                                 % (trace.lineno, trace.filename)
                             )
+                            default_html = None
 
                     # Render provided default;
                     # if no stub data supplied.
-                    return default_html
+                    return default_html or ""
                 else:
                     logger.warning(
                         'No default or stub data defined for the "%s" tag in the "%s" template',