CMake C++ GTK 3 Community Template #278
Conversation
leograba
changed the title
leograba
changed the title
leograba
force-pushed
the
gtk3-community-template
branch
from
8a22c14 to
ed27c67
Compare
|
Tested on This PR is ready for review. |
leograba
force-pushed
the
gtk3-community-template
branch
3 times, most recently
from
0490422 to
dfe452b
Compare
cmakeGTK3/Dockerfile
Outdated
| RUN apt-get -q -y update && \ | ||
| apt-get -q -y install \ | ||
| cmake \ | ||
| libgtk-3-dev:${IMAGE_ARCH} \ |
There was a problem hiding this comment.
I just found out that this does not work because for arm32, IMAGE_ARCH is arm, but apt uses :armhf. But this is a use case we need to support, not just for this template but for any template. Here there are two possible options:
- Use
iffor the install, like in here - Modify the templates to have a
torizonPackages.json, instead of creating it on project creation, to have at least the dependencies that depend on the architecture there
Probably will be nice to quickly discuss this on a meeting (like on the grooming)
There was a problem hiding this comment.
Modify the templates to have a torizonPackages.json, instead of creating it on project creation, to have at least the dependencies that depend on the architecture there
I like it. In fact, in my tests I was using the torizonPackages.json but then in the template I didn't use it because I thought this was a file that was mandatory to be left empty in the template. More or less like:
- Keep the base required files for the template to work on the Dockerfile directly
- Keep the
torizonPackages.jsononly for the user
But not sure what makes most sense here.
There was a problem hiding this comment.
This should be fixed with ddf6eae
cmakeGTK3/Dockerfile
Outdated
| apt-get install -y --no-install-recommends \ | ||
| libgtk-3-0 \ | ||
| RUN apt-get -y update && apt-get install -y --no-install-recommends \ | ||
| libgtk-4-1 \ |
There was a problem hiding this comment.
Should it be GTK 4 and not GTK 3 here?
There was a problem hiding this comment.
Oops, my mistake!
Fixed by 7ad4338
microhobby
force-pushed
the
dev
branch
14 times, most recently
from
9f045f0 to
65ae09b
Compare
microhobby
force-pushed
the
dev
branch
7 times, most recently
from
97f62c0 to
e169b0e
Compare
|
@leograba Please add a gtk3.png image at assets/img |
This is done |
leograba
force-pushed
the
gtk3-community-template
branch
from
7ad4338 to
a0ddf4b
Compare
For the new Slint templates, the status was updated to ok, as we do not have any known issues with them. Signed-off-by: Matheus Castello <[email protected]>
Create a template for GTK 3, based on the cmakeConsole. Use the "torizon/wayland-gtk3" container as base for the runtime. Signed-off-by: Leonardo Graboski Veiga <[email protected]>
Cross compilation had some issues with the GTK 4 template due to Debian dependencies. To keep the GTK 3 and GTK 4 templates as close as possible, move both to using native compilation (with the help of QEMU emulation). This also solves an issue with 32-bit Arm cross-compilation specific to the IDE Templates variable substitution. Signed-off-by: Leonardo Graboski Veiga <[email protected]>
Signed-off-by: Leonardo Graboski Veiga <[email protected]>
This was a mistake due to developing templates both for GTK 3 and 4. Signed-off-by: Leonardo Graboski Veiga <[email protected]>
Signed-off-by: Matheus Castello <[email protected]>
microhobby
force-pushed
the
gtk3-community-template
branch
from
a0ddf4b to
a0508ae
Compare
|
LGTM thanks @leograba ! |
Create a CMake C++ GTK 3 community template (sponsored by Toradex, but not regularly maintained like the Toradex-supported ones).
This template is based on the cmakeConsole and modified inspired on the cppQML for enabling graphics.
This PR is a fork of #268 and depends on toradex/vscode-torizon-templates-documentation#16