Added footer html & both css #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
itsashishbharti
commented
Jan 23, 2024
itsashishbharti
commented
srikant96
suggested changes
Jan 23, 2024
blogs/01/index.html
Outdated
| @@ -64,5 +71,43 @@ <h4>Subscribe to our Newsletter</h4> | |||
| </div> | |||
| </div> | |||
| </section> | |||
| <section id="footersec"> | |||
There was a problem hiding this comment.
use full-name in id , it should be id=footer or id=footer-section
blogs/01/index.html
Outdated
Comment on lines
83
to
86
| <li><a href=" ">About Us</a></li> | ||
| <li><a href=" ">Advertise</a></li> | ||
| <li><a href=" ">Careers</a></li> | ||
| <li><a href=" ">Subscribes</a></li> |
There was a problem hiding this comment.
use #about, #careers in all href tag.
blogs/01/index.html
Outdated
Comment on lines
89
to
92
| <li><a href=" ">Travel</a></li> | ||
| <li><a href=" ">Lifestyle</a></li> | ||
| <li><a href=" ">Sports</a></li> | ||
| <li><a href=" ">Nature</a></li> |
There was a problem hiding this comment.
use #travel, #nature in all href tag.
blogs/01/index.html
Outdated
Comment on lines
98
to
102
| <a href=""><img src="img/facebook.png"/></a> | ||
| <a href=""><img src="img/twitter.png"/></a> | ||
| <a href=""><img src="img/insta.png"/></a> | ||
| <a href=""><img src="img/wif.png"/></a> | ||
| <a href=""><img src="img/email.png"/></a> |
There was a problem hiding this comment.
use #facbook, #twitter in all href tag.
Comment on lines
+112
to
+114
| h3 , p { | ||
| font-size:16px; | ||
| } |
There was a problem hiding this comment.
use class name to change the font-size , other wise it will change the size of all headings and paragraph in every section.
|
resolve the conflicts @itsashishbharti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.