forked from matrix-org/matrix-rust-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Room::subscribe_to_live_location_shares
to Room::observable_live_location_share
#1
Open
Hywan
wants to merge
2
commits into
torrybr:feat/subscribe-beacons
Choose a base branch
from
Hywan:pr/4025
base: feat/subscribe-beacons
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
// Copyright 2024 The Matrix.org Foundation C.I.C. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
//! Types for live location sharing. | ||
|
||
use async_stream::stream; | ||
use ruma::{ | ||
events::{ | ||
beacon::OriginalSyncBeaconEvent, beacon_info::BeaconInfoEventContent, | ||
location::LocationContent, | ||
}, | ||
MilliSecondsSinceUnixEpoch, OwnedUserId, RoomId, | ||
}; | ||
|
||
use crate::{event_handler::ObservableEventHandler, Client, Room}; | ||
use futures_util::Stream; | ||
|
||
/// An observable live location. | ||
#[derive(Debug)] | ||
pub struct ObservableLiveLocation { | ||
observable_room_events: ObservableEventHandler<(OriginalSyncBeaconEvent, Room)>, | ||
} | ||
|
||
impl ObservableLiveLocation { | ||
/// Create a new `ObservableLiveLocation` for a particular room. | ||
pub(crate) fn new(client: &Client, room_id: &RoomId) -> Self { | ||
Self { observable_room_events: client.observe_room_events(room_id) } | ||
} | ||
|
||
/// Get a stream of [`LiveLocationShare`]. | ||
pub fn subscribe(&self) -> impl Stream<Item = LiveLocationShare> { | ||
let stream = self.observable_room_events.subscribe(); | ||
|
||
stream! { | ||
for await (event, room) in stream { | ||
yield LiveLocationShare { | ||
last_location: LastLocation { | ||
location: event.content.location, | ||
ts: event.content.ts, | ||
}, | ||
beacon_info: room | ||
.get_user_beacon_info(&event.sender) | ||
.await | ||
.ok() | ||
.map(|info| info.content), | ||
user_id: event.sender, | ||
}; | ||
} | ||
} | ||
} | ||
} | ||
|
||
/// Details of the last known location beacon. | ||
#[derive(Clone, Debug)] | ||
pub struct LastLocation { | ||
/// The most recent location content of the user. | ||
pub location: LocationContent, | ||
/// The timestamp of when the location was updated. | ||
pub ts: MilliSecondsSinceUnixEpoch, | ||
} | ||
|
||
/// Details of a users live location share. | ||
#[derive(Clone, Debug)] | ||
pub struct LiveLocationShare { | ||
/// The user's last known location. | ||
pub last_location: LastLocation, | ||
/// Information about the associated beacon event. | ||
pub beacon_info: Option<BeaconInfoEventContent>, | ||
/// The user ID of the person sharing their live location. | ||
pub user_id: OwnedUserId, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot use
StreamExt::map
becauseroom.get_user_beacon_info
is used inside this map, and is an async method. Instead, we use thestream!
macro, which does the job too.