Replace kwargs with SqlContext in get_sql #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
abondar
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
kwargsofget_sqlwith theSqlContextdataclass. This improves performance of SQL generation because the removal ofkwargseliminates the need to create adicton eachget_sqlinvocation. Also the dataclass explicitly documents all possible parameters as opposed tokwargsthat made it quite hard to track.For performance metrics, see the tortoise-orm PR, which is dependent on this PR.
This PR also adds the
warn_unused_ignores = truemypy option and removes unnecessary type ignores.This PR bumps version to 0.5.0.