-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve type hints for backends #1660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9559961752Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9562810843Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9565173623Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9565355799Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 10194560214Details
💛 - Coveralls |
waketzheng
force-pushed
the
type-hint-backends
branch
from
July 31, 2024 14:53
eb24766
to
e353b97
Compare
@abondar Only improve type hint, and does not change any code logic. Can this be accepted? |
abondar
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve type hints to reduce
type:ignore
Motivation and Context
Improve type hint of tortoise/backends without changing any code logic
How Has This Been Tested?
make test
Checklist: