Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return deterministic user tracking id and remove celeste #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

himanshuchawla009
Copy link
Member

@himanshuchawla009 himanshuchawla009 commented Feb 13, 2025

  • Add trackingId query param, use default trackingId if not enabled.
    • Idea of this tracking id in query params is to track user's end to end request flow during a timestamp
    • Default tracking id is deterministic so it also helps in audit trail to search for all logs for a user in all services.
    • This should only be enabled when required for performance testing and debugging because adding query param disables preflight request caching. So by default it should remain off.
  • Remove celeste
  • Remove network path from tss and rss endpoints (since those endpoints doesnt works for legacy networks)

Future improvements:-

  1. Enable tracking per verifier basis (dynamically), we will need to add some persistence in that case. Currently tracking can be enabled only from sdk or by changing env variable.

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants