Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pomelo: graphical forth shell #261

Merged
merged 34 commits into from
Aug 31, 2023
Merged

Pomelo: graphical forth shell #261

merged 34 commits into from
Aug 31, 2023

Conversation

spookyvision
Copy link
Contributor

This PR adds a graphical forth shell to pomelo, simulating the experience of an actual device. The previous terminal shell is available in parallel.

@hawkw hawkw requested review from jamesmunns and hawkw August 29, 2023 21:39
Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm fine with merging this as-is --- it's great that it works!

i had some thoughts for potentially improving the way we handle the JS callbacks, though. if you look at the way the drivers for Real Hardware platforms like the D1 work, we tend to have an interrupt handler (which, like a JS callback, can't execute async code) wake the async task that does all the Real Async Work like sending responses to clients of the driver and so on. i wonder if it would be possible to use a similar design here, instead of having to spawn a new task in the callback just to send to a channel.

i understand if you'd prefer to get this PR merged sooner without rewriting that code, though, so i'm fine with saving that for a follow-up. it might help us avoid some of the problems we've had with callback/async interactions, though...

platforms/pomelo/src/main.rs Outdated Show resolved Hide resolved
platforms/pomelo/src/main.rs Outdated Show resolved Hide resolved
platforms/pomelo/src/main.rs Outdated Show resolved Hide resolved
platforms/pomelo/src/main.rs Outdated Show resolved Hide resolved
platforms/pomelo/src/sim_drivers/emb_display.rs Outdated Show resolved Hide resolved
platforms/pomelo/src/sim_drivers/emb_display.rs Outdated Show resolved Hide resolved
platforms/pomelo/src/sim_drivers/emb_display.rs Outdated Show resolved Hide resolved
platforms/pomelo/src/sim_drivers/emb_display.rs Outdated Show resolved Hide resolved
platforms/pomelo/src/main.rs Outdated Show resolved Hide resolved
@spookyvision spookyvision merged commit 699928d into main Aug 31, 2023
7 checks passed
@spookyvision spookyvision deleted the pomelo-graphics branch August 31, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants