-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Correct import path and Add Chinese on Giscus language #144
Conversation
* Fixed an issue where the Chinese locale was not applied in Giscus
* Fixed an incorrect import path in ( β ).
@clicelee is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
Like in other Toss library documents, I also thought it would be better to use more standard language codes like If we were to make changes, I think we should use lowercase for these language codes (zh-hans, zh-cn) rather than mixed case (zh-Hans, zh-CN) since they're used in URL paths. This ensures consistent behavior across different systems and follows established URL standards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the detailed explanation @clicelee , @Seol-JY π
β ch is non-standard and should not be used.
β Using zh alone cannot distinguish between Simplified and Traditional Chinese.
β
zh-Hans is recommended as it covers all Simplified Chinese users.
π For URLs, using lowercase (zh-hans) is more appropriate (e.g., example.com/zh-hans/).
It'll be great if you can make another PR for changing folder name /ch β /zh-hans .
I'll do it right away π |
* Fix: Ensure Giscus supports Chinese * Fixed an issue where the Chinese locale was not applied in Giscus * Fix: Correct import path for Chinese locale * Fixed an incorrect import path in ( β ). * Revert: yarn.lock
* fix: change LCP image from png to webp * docs: κ°μ²΄ μ€κ΅μ΄ λ²μ (#120) * chore: create ch files * docs: translate into simplified chinese * docs: translate into simplified chinese * docs: translate into simplified chinese * docs: translate into simplified chinese * docs: translate into simplified chinese * docs: translate into simplified chinese * refactor: substitute with suitable terms * docs: translate into simplified chinese * feat: add chSearch * fix: change chSearch option * fix: fix typo with inspection * οΏ½fix: fix typo in hidden-logic.md εζΆ -> εδΊ Co-authored-by: Jinyeong Seol <[email protected]> * feat: implement dark mode image support in markdown * docs: improve item-edit-modal.md by adding abstraction concepts * fix: correct localized link --------- Co-authored-by: Jinyeong Seol <[email protected]> * Fix: Corrected localized link to Amazon (#141) - The link was still redirecting to Yes24, so the link was updated properly * Fix: Correct import path and Add Chinese on Giscus language (#144) * Fix: Ensure Giscus supports Chinese * Fixed an issue where the Chinese locale was not applied in Giscus * Fix: Correct import path for Chinese locale * Fixed an incorrect import path in ( β ). * Revert: yarn.lock * οΏ½Fix: Add missing syntax and normalize Auth Token usage (#145) * fix: Add missing 'from' keyword in import statement * fix: Add missing period in email validation error message(ko) * fix: add auth token to HTTP header * fix: resolve badge component rendering issue by extending default theme (#146) * feat: add webp Image in chinese ver. --------- Co-authored-by: Owon <[email protected]> Co-authored-by: Jinyeong Seol <[email protected]> Co-authored-by: ππ π π π <[email protected]>
π Key Changes
ch.mjs
was incorrectly used. Changed it toch.mts
config.mts
utils/index.ts
ch: "zh-CN"
toGISCUS_LANG_MAP
.π€ Discussion
ch
, but according to ISO 639-1,zh
might be more appropriate.πΌοΈ Before and After Comparison
Key Change 2: added chinese to
GISCUS_LANG_MAP
.utils/index.ts