feat: Embeing GitHub Discussions into Frontend Fundamentals #167
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.vitepress/ko.mts
Outdated
| text: "디스커션 보기", | ||
| link: "/code/dicussions/table" | ||
| }, |
There was a problem hiding this comment.
How about adding 'community' to path?
e.g "/code/community/dicussions/table"
There was a problem hiding this comment.
Sure, I Will Change Category Name 💯
There was a problem hiding this comment.
I noticed that there appears to be a small typo in the path. The current spelling is dicussions, but I believe the correct spelling should be discussions. Also, it seems the folder path code/dicussions would need to be updated to code/discussions!
| sortField, | ||
| sortDirection, | ||
| handleSort | ||
| } = useGithubDiscussions(props.owner, props.repo, { |
There was a problem hiding this comment.
this.props is passed by component.
do you think this way is dangerous 👀 ?
<GithubDiscussions owner="toss" repo="frontend-fundamentals" />
api/github.js
Outdated
| export default async function handler(req, res) { | ||
| const { query, variables } = req.body || {}; | ||
|
|
||
| if (!query) { | ||
| return res.status(400).json({ error: 'Missing "query" in request body' }); | ||
| } | ||
|
|
||
| const GITHUB_ACCESS_TOKEN = process.env.READ_GITHUB_DISCUSSION_ACCESS_TOKEN; | ||
|
|
||
| if (!GITHUB_ACCESS_TOKEN) { | ||
| return res.status(500).json({ error: "Missing API Key" }); | ||
| } | ||
|
|
||
| return fetch("https://api.github.com/graphql", { | ||
| method: "POST", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| Authorization: `Bearer ${GITHUB_ACCESS_TOKEN}` | ||
| }, | ||
| body: JSON.stringify({ query }) | ||
| }); | ||
| } |
There was a problem hiding this comment.
But doesn't it reveals token on the network tab?
There was a problem hiding this comment.
I understand that if I use a serverless function, only the response provided by the Vercel server is exposed. 👀
| <a :href="discussion.url" target="_blank">{{ | ||
| discussion.title | ||
| }}</a> | ||
| <span v-if="discussion.closed" class="closed-badge">닫힘</span> |
There was a problem hiding this comment.
How about using other word? e.g...
- 완료
- 정리 완료
- 🎯 마무리된 토론
📝 Key Changes
🖼️ Before and After Comparison