refactor(useVisibilityEvent): optimize useVisibilityEvent hook with usePreservedCallback to prevent unnecessary effect #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the
useVisibilityEvent
hook to useusePreservedCallback
for the visibility change handler.By doing so, the
handleVisibilityChange
function reference remains stable across component re-renders, preventinguseEffect
from unnecessarily re-executing and re-attaching event listeners.This reduces the overhead of continuously adding and removing the
visibilitychange
event listener, providing a performance boost.Additionally, even when the
callback
changes,usePreservedCallback
ensures the latest callback is always invoked, maintaining correctness.Added initial values to the
options.immediate
documentation.Checklist
yarn run fix
to format and lint the code and docs?yarn run test:coverage
to make sure there is no uncovered line?