refactor(mergeProps): mergeProps by removing redundant undefined check and simplifying style merging logic #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the
mergeProps
utility function by:Removing redundant checks for
undefined
in thepushProp
function.Since the
if (curr[key] === undefined) continue;
statement is already handled at the start of the loop, the additionalelse if (curr[key] !== undefined)
check inside thedefault
case is unnecessary and removed for clarity.Simplifying the
mergeStyle
function by removing the null check for the first style argument.In practice,
a
is nevernull
but can beundefined
.Spreading potentially
undefined
values with{ ...a, ...b }
safely results in identical behavior without extra branching logic.These changes clean up the code, improve maintainability, and have no effect on the existing behavior or output of the utility.
Checklist
yarn run fix
to format and lint the code and docs?yarn run test:coverage
to confirm test coverage?